Skip to content

RTDB exists() should return true for falsy values (e.g. 0, false, "") #1410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 12, 2023
Merged

RTDB exists() should return true for falsy values (e.g. 0, false, "") #1410

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1037e84
rtdb.exists returns true for falsy values
inlined May 31, 2023
e9efb45
Merge branch 'master' into inlined.falsy-fix
taeold Jun 12, 2023
69035f5
Update package.json
taeold Jun 12, 2023
3989423
Update database.spec.ts
taeold Jun 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions spec/v1/providers/database.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -580,6 +580,15 @@ describe("DataSnapshot", () => {
populate({ a: [{}] });
expect(subject.child("a").exists()).to.be.false;
});

it("should be true for a falsy value (other than null)", () => {
populate({ num: 0, bool: false, n: null });
expect(subject.exists()).to.be.true;
expect(subject.child("num").exists()).to.be.true;
expect(subject.child("bool").exists()).to.be.true;
expect(subject.child("n").exists()).to.be.false;
expect(subject.child("missing").exists()).to.be.false;
});
});

describe("#forEach(action: (a: DataSnapshot) => boolean): boolean", () => {
Expand Down
2 changes: 1 addition & 1 deletion src/common/providers/database.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,7 +159,7 @@ export class DataSnapshot implements database.DataSnapshot {
*/
exists(): boolean {
const val = this.val();
if (!val || val === null) {
if (typeof val === "undefined" || val === null) {
return false;
}
if (typeof val === "object" && Object.keys(val).length === 0) {
Expand Down