Skip to content

Change typoed function name in Params #1284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 8, 2022
Merged

Change typoed function name in Params #1284

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c0446aa
Change typoed function name in Params
Berlioz Oct 27, 2022
f14386c
Merge remote-tracking branch 'origin' into deprecate_typo_function
Berlioz Nov 8, 2022
88f96ac
changelog
Berlioz Nov 8, 2022
5435a3c
format fix
Berlioz Nov 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
- Deprecate typoed function name lessThanorEqualTo (#1284)
10 changes: 9 additions & 1 deletion src/params/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -297,10 +297,18 @@ export abstract class Param<T extends string | number | boolean | string[]> exte
}

/** Returns a parametrized expression of Boolean type, based on comparing the value of this param to a literal or a different expression. */
lessThanorEqualTo(rhs: T | Expression<T>) {
lessThanOrEqualTo(rhs: T | Expression<T>) {
return this.cmp("<=", rhs);
}

/**
* Returns a parametrized expression of Boolean type, based on comparing the value of this param to a literal or a different expression.
* @deprecated A typo. Use lessThanOrEqualTo instead.
*/
lessThanorEqualTo(rhs: T | Expression<T>) {
return this.lessThanOrEqualTo(rhs);
}

toString(): string {
return `params.${this.name}`;
}
Expand Down