Print a warning when Expression.value() is invoked during discovery #1257
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taeold
reviewed
Oct 10, 2022
src/params/types.ts
Outdated
| return this.runtimeValue(); | ||
| } | ||
|
|
||
| // @internal |
There was a problem hiding this comment.
Do we need @internal tag on all of implementation of runtimeValue?
There was a problem hiding this comment.
Possibly, and while I was down the rabbit hole of looking that up, I also realized that tsc doesn't respect jsdoc annotations unless they're in, well, jsdoc format, so fixing that too.
Comment on lines
+87
to
+88
| runtimeValue(): T { | ||
| return this.test.runtimeValue() ? valueOf(this.ifTrue) : valueOf(this.ifFalse); |
There was a problem hiding this comment.
woah we are renaming value to runtimeValue()?
There was a problem hiding this comment.
Not from users' perspective. They'll still call value(), which will use the implementation in the base Expression class, which will do the discovery check and then call runtimeValue()
Co-authored-by: Daniel Lee <[email protected]>
taeold
reviewed
Oct 11, 2022
taeold
approved these changes
Oct 12, 2022
Berlioz
force-pushed
the
warn_on_exec_value
branch
from
8bfbb09 to
bf724c4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the neatest way I can think of to implement this off the top of my head, which means there's an excellent chance that there's a neater way to do it that I didn't think of.