Skip to content

Fix common identity package internal toJSON function #1125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 16, 2022
Merged

Fix common identity package internal toJSON function #1125

merged 3 commits into from
May 16, 2022

Conversation

colerogers
Copy link
Contributor

Fixes #1102

@colerogers colerogers requested review from inlined and TheIronDev May 12, 2022 14:30
TheIronDev
TheIronDev reviewed May 13, 2022
View reviewed changes
src/common/providers/identity.ts Outdated
json.providerData = record.providerData.map((entry) => {
const newEntry = { ...entry };
newEntry.toJSON = () => {
return entry;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tiny nit:

newEntry.toJSON = () => entry;

@colerogers colerogers merged commit cb90fab into master May 16, 2022
@colerogers colerogers deleted the colerogers.fix-to-json-identity-common branch May 16, 2022 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@inlined inlined Awaiting requested review from inlined

1 more reviewer

@TheIronDev TheIronDev TheIronDev approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TypeError: entry.toJSON is not a function
2 participants
@colerogers @TheIronDev