Skip to content

Require auth token but skip verification for tasks queue functions. #1073

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 12, 2022
Merged

Require auth token but skip verification for tasks queue functions. #1073

merged 2 commits into from
Apr 12, 2022

Conversation

taeold
Copy link
Contributor

@taeold taeold commented Apr 11, 2022 •
edited
Loading

Previously, we allowed TQ functions to either:

  1. Not have any auth token
  2. Have admin SDK verified auth tokens.

Since TQ functions are guarded by IAM, we instead implement the following behavior:

  1. MUST have auth token
  2. Do not verify auth token - instead we just decode it and pass it to the handler

@taeold taeold requested review from inlined and colerogers April 11, 2022 22:05
@taeold taeold merged commit 60a7a40 into master Apr 12, 2022
@taeold taeold deleted the dl-tq-auth branch April 12, 2022 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@inlined inlined inlined approved these changes

@colerogers colerogers Awaiting requested review from colerogers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@taeold @inlined