Specific interface for provider enhancement (2/3)

[colerogers]

Change for the the specific billing interface. Exposes onPlanUpdatePublished & onAutomatedPlanUpdatePublished from the v2/alerts/billing namespace

Ex ~

import {
  onPlanUpdatePublished,
  onAutomatedPlanUpdatePublished
} from "firebase-functions/v2/alerts/billing";

// planUpdatePublished interface
export const func1 = onPlanUpdatePublished((event) => { … });
export const func2 = onPlanUpdatePublished({ region: "us-west1" }, (event) => { … });
// robotPlanUpdatePublished interface
export const func3 = onAutomatedPlanUpdatePublished((event) => { … });
export const func5 = onAutomatedPlanUpdatePublished({ region: "us-west1" }, (event) => { … });

[taeold]

Woo (event: BillingEvent<T>) => any | Promise<any>; is used thrice! This meets the threshold for DRY for me:

type BillingEventHandler<T> = (event: BillingEvent<T>) => any | Promise<any>;

[colerogers]

Oh that looks way better, thanks for the suggestion!

[colerogers]

@taeold Removed based on typing feedback below

[taeold]

🔥 Great stuff.

[inlined]

This typedef makes code complete worse (it asks for a BillingEventHandler instead of a function signature)

[colerogers]

Oh shoot, we should probably change it back for better usability then, right?

[taeold]

I wanted to test out the automcomplete and see what shows, but I couldn't get to any of the billing handlers at all.

@colerogers Can you double check if this is working for you?

1. npm run build:pack
2. Install the generated tgz locally on your function
3. Try to get import to work.

[taeold]

In fact, I couldn't even get lib/v2/providers/billing.js to show up. what gives?

[colerogers]

@taeold I was able to get it to work, just pushed an update. Seems like we can't rely on the package.json export path alone, we need to also export from the root index.ts. I think there was a comment about exporting on one of the other PRs and I ended up changing it on all of them

[colerogers]

@inlined Removed BillingEventHandler type from the latest commit