Skip to content

Specific interface for provider enhancement (1/3) #1021

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Jan 27, 2022

Conversation

colerogers
Copy link
Contributor

@colerogers colerogers commented Jan 19, 2022

Change for the the specific app distro interface. Exposes onNewTesterIosDevicePublished from the v2/alerts/appDistribution namespace

Ex ~

import { onNewTesterIosDevicePublished } from "firebase-functions/v2/alerts/appDistribution";

// newTesterIosDevicePublished interface
export const func = onNewTesterIosDevicePublished((event) => { … });
export const func1 = onNewTesterIosDevicePublished("123456789", (event) => { … });
export const func2 = onNewTesterIosDevicePublished({ appId: "123456789" }, (event) => { … });

@colerogers colerogers requested review from taeold and inlined January 19, 2022 23:05
@colerogers colerogers changed the title Specific interface for provider enhancement Specific interface for provider enhancement (1/3) Jan 19, 2022
Copy link
Contributor

@taeold taeold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mostly lgtm. waiting on some changes to flow from #1020.

@colerogers colerogers requested a review from taeold January 24, 2022 22:23
Copy link
Contributor

@taeold taeold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm w/ a comment on adding punctuation on public doc strings.

Copy link
Member

@inlined inlined left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love it

@colerogers colerogers merged commit 01de80b into colerogers.alerts Jan 27, 2022
@colerogers colerogers deleted the colerogers.appDistribution branch January 27, 2022 17:29
colerogers added a commit that referenced this pull request Jan 28, 2022
* breaking out general interface

* cleaning up exports

* removing comments & references to specific interfaces

* format

* jsdoc comments

* address pr comments

* added param comment

* addressing comments

* Specific interface for provider enhancement (1/3) (#1021)

* adding in app distro changes

* removing comments & addings package refs

* jsdoc comments

* fix comments

* adding periods to doc strings

* fix wording

* adding import/export statement

* Specific interface for provider enhancement (2/3) (#1022)

* adding in billing changes

* removing comments & adding package refs

* jsdoc comments

* addressing pr comments

* change handler doc string

* changing to BillingEventHandler type

* remove BillingEventHandler type

* Specific interface for provider enhancement (3/3) (#1023)

* adding in crashlytics changes

* comments & adding package refs

* address comments and make doc strings better

* add opts.retry to event trigger
colerogers added a commit that referenced this pull request Jan 31, 2022
* breaking out general interface

* cleaning up exports

* removing comments & references to specific interfaces

* format

* jsdoc comments

* address pr comments

* added param comment

* addressing comments

* Specific interface for provider enhancement (1/3) (#1021)

* adding in app distro changes

* removing comments & addings package refs

* jsdoc comments

* fix comments

* adding periods to doc strings

* fix wording

* adding import/export statement

* Specific interface for provider enhancement (2/3) (#1022)

* adding in billing changes

* removing comments & adding package refs

* jsdoc comments

* addressing pr comments

* change handler doc string

* changing to BillingEventHandler type

* remove BillingEventHandler type

* Specific interface for provider enhancement (3/3) (#1023)

* adding in crashlytics changes

* comments & adding package refs

* address comments and make doc strings better

* add opts.retry to event trigger
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants