Skip to content

Update Android BOM to 30.1.0 in integration tests and readme #995

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 17, 2022
Merged

Update Android BOM to 30.1.0 in integration tests and readme #995

merged 1 commit into from
Jun 17, 2022

Conversation

DellaBitta
Copy link
Contributor

Description

Provide details of the change, and generalize the change in the PR title above.

There were places where we were still using the older BOM version 30.0.0. Update those places so that we're consistently using BOM 30.1.0.

Testing

Describe how you've tested these changes. Link any manually triggered Integration tests or CPP binary SDK Packaging Github Action workflows, if applicable.

Triggered Intergration Tests on this PR.

Type of Change

Place an x the applicable box:

  • Bug fix. Add the issue # below if applicable.
  • New feature. A non-breaking change which adds functionality.
  • Other, such as a build process or documentation change.

@DellaBitta DellaBitta added the tests-requested: quick Trigger a quick set of integration tests. label Jun 16, 2022
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. and removed tests-requested: quick Trigger a quick set of integration tests. labels Jun 16, 2022
@github-actions
Copy link

github-actions bot commented Jun 16, 2022 •
edited
Loading

❌  Integration test FAILED

Requested by @DellaBitta on commit 77945e0
Last updated: Fri Jun 17 08:05 PDT 2022
View integration test log & download artifacts

Failures Configs
firestore [TEST] [ERROR] [MacOS] [x64] [openssl]
[TEST] [FAILURE] [iOS] [macos] [1/2 ios_device: simulator_target]
(1 failed tests)  NumericTransformsTest.CreateDocumentWithIncrement
[TEST] [FLAKINESS] [Android] [1/3 os: macos] [1/2 android_device: android_target]
(1 failed tests)  CRASH/TIMEOUT

Add flaky tests to go/fpl-cpp-flake-tracker

@DellaBitta DellaBitta changed the title Update Android BOM to 30.1.0 in iTests and ReadMe Update Android BOM to 30.1.0 in integration tests and readme Jun 16, 2022
@github-actions github-actions bot added the tests: succeeded This PR's integration tests succeeded. label Jun 16, 2022
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Jun 16, 2022
@DellaBitta DellaBitta merged commit 77945e0 into main Jun 17, 2022
@DellaBitta DellaBitta deleted the internal/consistent_bom branch June 17, 2022 12:26
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. tests: failed This PR's integration tests failed. and removed tests: succeeded This PR's integration tests succeeded. labels Jun 17, 2022
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Jun 17, 2022
@firebase firebase locked and limited conversation to collaborators Jul 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@a-maurice a-maurice a-maurice approved these changes

@jonsimantov jonsimantov Awaiting requested review from jonsimantov

Assignees
No one assigned
Labels
tests: failed This PR's integration tests failed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DellaBitta @a-maurice