Skip to content

Use NDK r21e (installed by prereqs script) for Android builds. #986

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 10, 2022
Merged

Use NDK r21e (installed by prereqs script) for Android builds. #986

merged 2 commits into from
Jun 10, 2022

Conversation

jonsimantov
Copy link
Contributor

Description

Provide details of the change, and generalize the change in the PR title above.

Testing

Describe how you've tested these changes. Link any manually triggered Integration tests or CPP binary SDK Packaging Github Action workflows, if applicable.

Type of Change

Place an x the applicable box:

  • Bug fix. Add the issue # below if applicable.
  • New feature. A non-breaking change which adds functionality.
  • Other, such as a build process or documentation change.

Notes

  • Bug fixes and feature changes require an update to the Release Notes section of release_build_files/readme.md.
  • Read the contribution guidelines CONTRIBUTING.md.
  • Changes to the public API require an internal API review. If you'd like to help us make Firebase APIs better, please propose your change in a feature request so that we can discuss it together.

@jonsimantov jonsimantov added the tests-requested: quick Trigger a quick set of integration tests. label Jun 9, 2022
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. and removed tests-requested: quick Trigger a quick set of integration tests. labels Jun 9, 2022
@github-actions
Copy link

github-actions bot commented Jun 9, 2022 •
edited
Loading

❌  Integration test FAILED

Requested by @jonsimantov on commit 20a0450
Last updated: Fri Jun 10 12:56 PDT 2022
View integration test log & download artifacts

Failures Configs
storage [TEST] [FAILURE] [MacOS] [x64] [openssl]
(1 failed tests)  FirebaseStorageTest.TestDeleteWithMaxRetryDuration

Add flaky tests to go/fpl-cpp-flake-tracker

@jonsimantov jonsimantov added skip-release-notes Skip release notes check and removed tests: in-progress This PR's integration tests are in progress. labels Jun 9, 2022
@jonsimantov jonsimantov enabled auto-merge (squash) June 9, 2022 21:16
@github-actions github-actions bot added the tests: failed This PR's integration tests failed. label Jun 9, 2022
@jonsimantov jonsimantov removed the tests: failed This PR's integration tests failed. label Jun 10, 2022
@jonsimantov jonsimantov merged commit 20a0450 into main Jun 10, 2022
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. tests: failed This PR's integration tests failed. labels Jun 10, 2022
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Jun 10, 2022
@firebase firebase locked and limited conversation to collaborators Jul 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@DellaBitta DellaBitta DellaBitta approved these changes

Assignees
No one assigned
Labels
skip-release-notes Skip release notes check tests: failed This PR's integration tests failed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jonsimantov @DellaBitta