DO NOT MERGE: firestore.cmake: point at HEAD commit in master branch: https://githu… #950
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… see if it fixes build errors in CI: lambda_event_listener.h:23:10: fatal error: 'firebase/firestore/firestore_errors.h' file not found
…esn't take as long
…clude to see if it fixes build errors in CI: lambda_event_listener.h:23:10: fatal error: 'firebase/firestore/firestore_errors.h' file not found" This change didn't fix anything. This reverts commit 7343ab5.
|
@wu-hui Thanks for taking this over from me. For the Android build error, it looks like it may not be nicely handling the modifications of |
|
Now that Snappy support has been added to the iOS SDK (firebase/firebase-ios-sdk#9596), building at head is quite a bit more complicated. This would should instead be continued in #932, which does the work to modify this repo to no longer patch in Snappy support. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test PR to see if the build works at the HEAD of the iOS SDK. I will close this PR once the "testing" is done.