Skip to content

Switch from individual Firebase Android SDK versions to Android BoM #949

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 18 commits into from
Jun 10, 2022
Merged

Switch from individual Firebase Android SDK versions to Android BoM #949

merged 18 commits into from
Jun 10, 2022

Conversation

jonsimantov
Copy link
Contributor

@jonsimantov jonsimantov commented May 10, 2022 •
edited
Loading

Description

Provide details of the change, and generalize the change in the PR title above.

Firebase Android BoM makes it much easier to specify Firebase Android dependency versions - there is only one version number to update. This updates our build and docs to use that instead of individual versions.

(Web docs will be updated separately.)

Testing

Describe how you've tested these changes. Link any manually triggered Integration tests or CPP binary SDK Packaging Github Action workflows, if applicable.

Running integration tests in this PR.
Running cpp packaging & packaging tests.

Type of Change

Place an x the applicable box:

  • Bug fix. Add the issue # below if applicable.
  • New feature. A non-breaking change which adds functionality.
  • Other, such as a build process or documentation change.

Notes

  • Bug fixes and feature changes require an update to the Release Notes section of release_build_files/readme.md.
  • Read the contribution guidelines CONTRIBUTING.md.
  • Changes to the public API require an internal API review. If you'd like to help us make Firebase APIs better, please propose your change in a feature request so that we can discuss it together.

@jonsimantov jonsimantov added the tests-requested: quick Trigger a quick set of integration tests. label May 10, 2022
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. and removed tests-requested: quick Trigger a quick set of integration tests. labels May 10, 2022
@github-actions
Copy link

github-actions bot commented May 10, 2022 •
edited
Loading

✅  Integration test succeeded!

Requested by @jonsimantov on commit 486bb50
Last updated: Fri Jun 10 13:39 PDT 2022
View integration test log & download artifacts

@github-actions github-actions bot added the tests: failed This PR's integration tests failed. label May 10, 2022
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label May 10, 2022
@jonsimantov jonsimantov added the tests-requested: quick Trigger a quick set of integration tests. label May 10, 2022
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. and removed tests-requested: quick Trigger a quick set of integration tests. tests: failed This PR's integration tests failed. labels May 10, 2022
@github-actions github-actions bot added the tests: failed This PR's integration tests failed. label May 10, 2022
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label May 10, 2022
@jonsimantov jonsimantov added the tests-requested: quick Trigger a quick set of integration tests. label May 11, 2022
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. tests: failed This PR's integration tests failed. and removed tests-requested: quick Trigger a quick set of integration tests. tests: failed This PR's integration tests failed. labels May 11, 2022
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label May 12, 2022
@jonsimantov jonsimantov added the tests-requested: quick Trigger a quick set of integration tests. label May 12, 2022
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. and removed tests-requested: quick Trigger a quick set of integration tests. tests: failed This PR's integration tests failed. labels May 12, 2022
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label May 13, 2022
@jonsimantov jonsimantov added the tests-requested: quick Trigger a quick set of integration tests. label May 13, 2022
@jonsimantov jonsimantov requested a review from DellaBitta May 13, 2022 07:32
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. tests: succeeded This PR's integration tests succeeded. and removed tests-requested: quick Trigger a quick set of integration tests. tests: succeeded This PR's integration tests succeeded. labels May 13, 2022
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label May 13, 2022
@jonsimantov jonsimantov marked this pull request as ready for review May 13, 2022 17:02
@jonsimantov
Copy link
Contributor Author

Will hold off on checking in until the Unity release goes out.

@jonsimantov jonsimantov added the tests-requested: quick Trigger a quick set of integration tests. label Jun 7, 2022
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. tests: succeeded This PR's integration tests succeeded. and removed tests-requested: quick Trigger a quick set of integration tests. tests: succeeded This PR's integration tests succeeded. labels Jun 7, 2022
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Jun 8, 2022
@jonsimantov jonsimantov merged commit 486bb50 into main Jun 10, 2022
@jonsimantov jonsimantov deleted the other/use-android-bom branch June 10, 2022 18:09
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. tests: succeeded This PR's integration tests succeeded. and removed tests: succeeded This PR's integration tests succeeded. labels Jun 10, 2022
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Jun 10, 2022
@firebase firebase locked and limited conversation to collaborators Jul 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@DellaBitta DellaBitta DellaBitta approved these changes

Assignees
No one assigned
Labels
tests: succeeded This PR's integration tests succeeded.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jonsimantov @DellaBitta