Skip to content

Fix path to python on windows desktop build. #910

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 20, 2022
Merged

Fix path to python on windows desktop build. #910

merged 2 commits into from
Apr 20, 2022

Conversation

jonsimantov
Copy link
Contributor

Description

Provide details of the change, and generalize the change in the PR title above.

Replicate the fix from build_testapps into build_desktop.

Testing

Describe how you've tested these changes. Link any manually triggered Integration tests or CPP binary SDK Packaging Github Action workflows, if applicable.

Type of Change

Place an x the applicable box:

  • Bug fix. Add the issue # below if applicable.
  • New feature. A non-breaking change which adds functionality.
  • Other, such as a build process or documentation change.

Notes

  • Bug fixes and feature changes require an update to the Release Notes section of release_build_files/readme.md.
  • Read the contribution guidelines CONTRIBUTING.md.
  • Changes to the public API require an internal API review. If you'd like to help us make Firebase APIs better, please propose your change in a feature request so that we can discuss it together.

@jonsimantov jonsimantov requested a review from a-maurice April 20, 2022 21:05
@jonsimantov jonsimantov added the skip-release-notes Skip release notes check label Apr 20, 2022
@jonsimantov jonsimantov merged commit 52d219b into main Apr 20, 2022
@jonsimantov jonsimantov deleted the bugfix/packaging_python_path branch April 20, 2022 23:59
@github-actions github-actions bot added the tests: in-progress This PR's integration tests are in progress. label Apr 20, 2022
@github-actions
Copy link

github-actions bot commented Apr 20, 2022 •
edited
Loading

✅  Integration test succeeded!

Requested by @jonsimantov on commit 52d219b
Last updated: Wed Apr 20 19:14 PDT 2022
View integration test log & download artifacts

@github-actions github-actions bot added the tests: succeeded This PR's integration tests succeeded. label Apr 21, 2022
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Apr 21, 2022
dconeybe
dconeybe reviewed Apr 21, 2022
View reviewed changes
scripts/gha/build_desktop.py
@@ -234,6 +235,8 @@ def cmake_configure(build_dir, arch, msvc_runtime_library='static', linux_abi='l
# on different windows machines.
cmd.append('-A')
cmd.append('Win32') if arch == 'x86' else cmd.append('x64')
# Also, for Windows, specify the path to Python.
cmd.append('-DFIREBASE_PYTHON_HOST_EXECUTABLE:FILEPATH=%s' % sys.executable)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO It would be a good idea to specify -DFIREBASE_PYTHON_HOST_EXECUTABLE for all OS's, not just Windows.

@firebase firebase locked and limited conversation to collaborators May 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dconeybe dconeybe dconeybe left review comments

@a-maurice a-maurice a-maurice approved these changes

Assignees
No one assigned
Labels
skip-release-notes Skip release notes check tests: succeeded This PR's integration tests succeeded.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jonsimantov @a-maurice @dconeybe