Skip to content

operator== and operator!= for DocumentChange #607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Aug 24, 2021
Merged

operator== and operator!= for DocumentChange #607

merged 6 commits into from
Aug 24, 2021

Conversation

ehsannas
Copy link
Contributor

No description provided.

@google-cla google-cla bot added the cla: yes label Aug 17, 2021
@ehsannas
Copy link
Contributor Author

This has to be rebased once #602 has landed.

dconeybe
dconeybe reviewed Aug 17, 2021
View reviewed changes
Copy link
Contributor

@dconeybe dconeybe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of drive-by comments. Enjoy :)

@var-const
Copy link
Contributor

@ehsannas Sorry I'm slow with these reviews, will definitely get to them tomorrow.

@ehsannas ehsannas self-assigned this Aug 18, 2021
var-const
var-const suggested changes Aug 18, 2021
View reviewed changes
var-const
var-const reviewed Aug 19, 2021
View reviewed changes
Copy link
Contributor

@var-const var-const left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ehsannas Also, I think readme needs to be updated as well.

@ehsannas ehsannas force-pushed the ehsann/add-operator-equals-dc branch from 6f784d0 to da7efde Compare August 20, 2021 18:51
@ehsannas ehsannas requested a review from var-const August 20, 2021 19:11
@ehsannas ehsannas assigned var-const and unassigned ehsannas Aug 20, 2021
@ehsannas ehsannas added the tests-requested: quick Trigger a quick set of integration tests. label Aug 21, 2021
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. and removed tests-requested: quick Trigger a quick set of integration tests. labels Aug 21, 2021
@github-actions
Copy link

github-actions bot commented Aug 21, 2021 •
edited
Loading

❌  Integration test FAILED

Requested by @ehsannas on commit c85d0ed
Last updated: Mon Aug 23 21:54 PDT 2021
View integration test log & download artifacts

Failures Configs
messaging [TEST] [ERROR] [Android] [All os] [android_target]

Add flaky tests to go/fpl-cpp-flake-tracker

@github-actions github-actions bot added the tests: succeeded This PR's integration tests succeeded. label Aug 21, 2021
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Aug 21, 2021
@ehsannas ehsannas requested a review from dconeybe August 23, 2021 20:41
@var-const var-const assigned ehsannas and unassigned var-const Aug 23, 2021
@ehsannas ehsannas merged commit c85d0ed into main Aug 24, 2021
@ehsannas ehsannas deleted the ehsann/add-operator-equals-dc branch August 24, 2021 01:11
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. tests: failed This PR's integration tests failed. and removed tests: succeeded This PR's integration tests succeeded. labels Aug 24, 2021
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Aug 24, 2021
@firebase firebase locked and limited conversation to collaborators Sep 24, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@var-const var-const var-const approved these changes

@dconeybe dconeybe Awaiting requested review from dconeybe

Assignees

@ehsannas ehsannas

Labels
api: firestore cla: yes tests: failed This PR's integration tests failed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ehsannas @var-const @dconeybe