Skip to content

operator== and operator!= for DocumentSnapshot. #602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Aug 20, 2021
Merged

operator== and operator!= for DocumentSnapshot. #602

merged 7 commits into from
Aug 20, 2021

Conversation

ehsannas
Copy link
Contributor

No description provided.

@google-cla google-cla bot added the cla: yes label Aug 12, 2021
@ehsannas ehsannas self-assigned this Aug 12, 2021
@ehsannas ehsannas added the tests-requested: quick Trigger a quick set of integration tests. label Aug 12, 2021
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. and removed tests-requested: quick Trigger a quick set of integration tests. labels Aug 12, 2021
@github-actions
Copy link

github-actions bot commented Aug 12, 2021 •
edited
Loading

❌  Integration test FAILED

Requested by @ehsannas on commit f331295
Last updated: Thu Aug 19 22:04 PDT 2021
View integration test log & download artifacts

Failures Configs
auth [TEST] [FAILURE] [Android] [ubuntu] [android_target]
(1 failed tests)  FirebaseAuthTest.TestUpdateEmailAndPassword
[TEST] [FAILURE] [MacOS] [openssl]
(1 failed tests)  FirebaseAuthTest.TestUpdateUserProfile
functions [TEST] [FAILURE] [MacOS] [openssl]
(1 failed tests)  FirebaseFunctionsTest.TestFunctionWithNull
messaging [TEST] [ERROR] [Android] [All os] [android_target]

Add flaky tests to go/fpl-cpp-flake-tracker

@github-actions github-actions bot added the tests: succeeded This PR's integration tests succeeded. label Aug 12, 2021
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Aug 12, 2021
@ehsannas ehsannas requested a review from var-const August 12, 2021 18:09
@ehsannas ehsannas assigned var-const and unassigned ehsannas Aug 12, 2021
var-const
var-const reviewed Aug 12, 2021
View reviewed changes
@var-const var-const assigned ehsannas and unassigned var-const Aug 12, 2021
var-const
var-const suggested changes Aug 13, 2021
View reviewed changes
var-const
var-const previously approved these changes Aug 13, 2021
View reviewed changes
@github-actions github-actions bot dismissed var-const’s stale review August 14, 2021 02:05

🍞 Dismissed stale approval on external PR.

@ehsannas ehsannas added tests-requested: quick Trigger a quick set of integration tests. and removed tests: succeeded This PR's integration tests succeeded. labels Aug 14, 2021
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. tests: failed This PR's integration tests failed. and removed tests-requested: quick Trigger a quick set of integration tests. labels Aug 14, 2021
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Aug 14, 2021
@ehsannas ehsannas requested a review from var-const August 15, 2021 18:44
@ehsannas ehsannas assigned var-const and unassigned ehsannas Aug 15, 2021
@ehsannas ehsannas mentioned this pull request Aug 17, 2021
Merged
var-const
var-const previously approved these changes Aug 18, 2021
View reviewed changes
Copy link
Contributor

@var-const var-const left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one comment.

@var-const var-const assigned ehsannas and unassigned var-const Aug 18, 2021
@github-actions github-actions bot dismissed var-const’s stale review August 19, 2021 15:42

🍞 Dismissed stale approval on external PR.

@ehsannas ehsannas added tests-requested: quick Trigger a quick set of integration tests. and removed tests: succeeded This PR's integration tests succeeded. labels Aug 19, 2021
@ehsannas ehsannas requested a review from var-const August 19, 2021 16:32
@ehsannas ehsannas assigned var-const and unassigned ehsannas Aug 19, 2021
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. tests: failed This PR's integration tests failed. and removed tests-requested: quick Trigger a quick set of integration tests. tests: failed This PR's integration tests failed. labels Aug 19, 2021
@var-const var-const assigned ehsannas and unassigned var-const Aug 19, 2021
@github-actions github-actions bot added the tests: succeeded This PR's integration tests succeeded. label Aug 19, 2021
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Aug 19, 2021
@ehsannas ehsannas merged commit f331295 into main Aug 20, 2021
@ehsannas ehsannas deleted the ehsann/add-operator-equals-3 branch August 20, 2021 02:06
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. tests: failed This PR's integration tests failed. and removed tests: succeeded This PR's integration tests succeeded. labels Aug 20, 2021
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Aug 20, 2021
@firebase firebase locked and limited conversation to collaborators Sep 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dconeybe dconeybe dconeybe left review comments

+1 more reviewer

@var-const var-const var-const approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@ehsannas ehsannas

Labels
api: firestore cla: yes tests: failed This PR's integration tests failed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ehsannas @var-const @dconeybe