Format Firestore source code with clang-format #477
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wu-hui
previously approved these changes
Jun 16, 2021
| @@ -37,7 +37,8 @@ class DocumentReferenceInternal : public Wrapper { | |||
|
|
|||
| DocumentReferenceInternal(FirestoreInternal* firestore, | |||
| const jni::Object& object) | |||
| : Wrapper(firestore, object), promises_(firestore) {} | |||
| : Wrapper(firestore, object), promises_(firestore) { | |||
| } | |||
There was a problem hiding this comment.
I prefer the old way.
Can you find out which config we can use to get the old way? I am OK to leave it if it takes you more than 10 minutes.
There was a problem hiding this comment.
Done. I just had to remove AllowShortFunctionsOnASingleLine: None from firestore/.clang-format.
wu-hui
approved these changes
Jun 17, 2021
github-actions
bot
added
the
tests: in-progress
✅ Integration test succeeded!Requested by @dconeybe on commit ce5aa57 |
dconeybe
added a commit
that referenced
this pull request
Jun 17, 2021
github-actions
bot
added
the
tests: succeeded
firebase-workflow-trigger
bot
removed
the
tests: in-progress
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.