Skip to content

Increase the visibility of the static methods in FirebaseTest #460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 15, 2021
Merged

Increase the visibility of the static methods in FirebaseTest #460

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8f52888
Increase the visibility of the static methods in FirebaseTest to 'pub…
dconeybe Jun 11, 2021
e666adf
Temporarily cherry-pick #462 so I can figure out why format_code.py i…
dconeybe Jun 11, 2021
4694ac6
Revert "Temporarily cherry-pick #462 so I can figure out why format_c…
dconeybe Jun 11, 2021
53f2356
Fix formatting issues in firebase_test_framework.h reported by clang-…
dconeybe Jun 11, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions testing/test_framework/src/firebase_test_framework.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -236,6 +236,10 @@ class FirebaseTest : public testing::Test {
// fully-automated tests should be run.
bool AreInteractiveTestsAllowed();

// Give the static helper methods "public" visibility so that they can be used
// by helper functions defined outside of subclasses of `FirebaseTest`, such
// as functions defined in anonymous namespaces.
public:
// Get a persistent string value that was previously set via
// SetPersistentString. Returns true if the value was set, false if not or if
// something went wrong.
Expand Down