Test Result Report Notification #459
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sunmou99
added
tests-requested: quick
github-actions
bot
removed
the
tests-requested: quick
github-actions
bot
added
the
tests: in-progress
✅ Integration test succeeded!Requested by @sunmou99 on commit a0e851c |
sunmou99
added
tests-requested: quick
github-actions
bot
added
tests: in-progress
sunmou99
added
the
tests-requested: quick
github-actions
bot
added
tests: in-progress
firebase-workflow-trigger
bot
removed
the
tests: in-progress
jonsimantov
reviewed
Jun 17, 2021
There was a problem hiding this comment.
- TODO: remove GitHub APP trigger
Not sure that this will be possible - without this, it's not possible for a workflow to trigger another workflow.
| _COMMENT_SUFFIX) | ||
| github.update_issue_comment(token, issue_number, comment) | ||
| else: | ||
| # github.delete_label(token, issue_number, _LABEL_SUCCEED) |
There was a problem hiding this comment.
How come these (and above) are commented out?
There was a problem hiding this comment.
Because we are reusing the same issue, the label logic makes the issue grows longer. Plus, I feel opening/closing issue suggesting the success/failure states.
Anthony and I talked about it during today's sync meeting. He agreed with what we have right now. But, we can definitely make some changes later with feedbacks.
I also updated the design doc When should we create a new Issue (pros and cons). Feel free to throw some comments
jonsimantov
previously approved these changes
Jun 17, 2021
sunmou99
added
the
tests-requested: quick
github-actions
bot
added
tests: in-progress
sunmou99
added
the
tests-requested: quick
github-actions
bot
removed
the
tests-requested: quick
jonsimantov
approved these changes
Jun 17, 2021
github-actions
bot
added
the
tests: succeeded
firebase-workflow-trigger
bot
removed
the
tests: in-progress
github-actions
bot
added
tests: in-progress
firebase-workflow-trigger
bot
removed
the
tests: in-progress
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
github.py: A utility for GitHub REST APIit_workflow.py: script which helps to update PR/Issue comments and labels during testing process.Added post-submit check:
github.event.action == 'closed' && github.event.pull_request.merged == trueCreated Nightly Test Result Report (repo)
TODO: Nightly Test Result Report for packaged SDK to be defined
TODO: remove GitHub APP trigger