Skip to content

Removing google play requirement. #361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 12, 2021
Merged

Removing google play requirement. #361

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6e7d4e2
Removing google play requirement.
vimanyu Apr 8, 2021
fbe072c
removing checks for google play services
vimanyu Apr 12, 2021
dc2dbfb
fixed release notes
vimanyu Apr 12, 2021
1416243
Merge branch 'main' into feature/remove-google-play-requirement
vimanyu Apr 12, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions auth/src/auth.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,6 @@
FIREBASE_APP_REGISTER_CALLBACKS(
auth,
{
FIREBASE_UTIL_RETURN_FAILURE_IF_GOOGLE_PLAY_UNAVAILABLE(*app);
return ::firebase::kInitResultSuccess;
},
{
Expand Down Expand Up @@ -75,8 +74,6 @@ Auth* Auth::GetAuth(App* app, InitResult* init_result_out) {
return existing_auth;
}

FIREBASE_UTIL_RETURN_NULL_IF_GOOGLE_PLAY_UNAVAILABLE(*app, init_result_out);

// Create the platform dependent version of Auth.
void* auth_impl = CreatePlatformAuth(app);
if (!auth_impl) return nullptr;
Expand Down
2 changes: 0 additions & 2 deletions database/src/common/database.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,6 @@
FIREBASE_APP_REGISTER_CALLBACKS(
database,
{
FIREBASE_UTIL_RETURN_FAILURE_IF_GOOGLE_PLAY_UNAVAILABLE(*app);
return ::firebase::kInitResultSuccess;
},
{
Expand Down Expand Up @@ -84,7 +83,6 @@ Database* Database::GetInstance(App* app, const char* url,
if (init_result_out != nullptr) *init_result_out = kInitResultSuccess;
return it->second;
}
FIREBASE_UTIL_RETURN_NULL_IF_GOOGLE_PLAY_UNAVAILABLE(*app, init_result_out);

Database* database = url ? new Database(app, new DatabaseInternal(app, url))
: new Database(app, new DatabaseInternal(app));
Expand Down
2 changes: 0 additions & 2 deletions functions/src/common/functions.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,6 @@
FIREBASE_APP_REGISTER_CALLBACKS(
functions,
{
FIREBASE_UTIL_RETURN_FAILURE_IF_GOOGLE_PLAY_UNAVAILABLE(*app);
return ::firebase::kInitResultSuccess;
},
{
Expand Down Expand Up @@ -84,7 +83,6 @@ Functions* Functions::GetInstance(::firebase::App* app, const char* region,
if (init_result_out != nullptr) *init_result_out = kInitResultSuccess;
return it->second;
}
FIREBASE_UTIL_RETURN_NULL_IF_GOOGLE_PLAY_UNAVAILABLE(*app, init_result_out);

Functions* functions = new Functions(app, region_idx.c_str());
if (!functions->internal_->initialized()) {
Expand Down
3 changes: 3 additions & 0 deletions release_build_files/readme.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -587,6 +587,9 @@ code.
- General: Fixed rare crashes at application exit when destructors were
being executed
([#345](https://github.com/firebase/firebase-cpp-sdk/pull/345)).
- General (Android): Removed checks for Google Play services for Auth, Database,
Functions and Storage as the native Android packages no longer need it.
([#361](https://github.com/firebase/firebase-cpp-sdk/pull/361)).

### 7.1.1
- Changes
Expand Down
2 changes: 0 additions & 2 deletions storage/src/common/storage.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,6 @@
FIREBASE_APP_REGISTER_CALLBACKS(
storage,
{
FIREBASE_UTIL_RETURN_FAILURE_IF_GOOGLE_PLAY_UNAVAILABLE(*app);
return ::firebase::kInitResultSuccess;
},
{
Expand Down Expand Up @@ -103,7 +102,6 @@ Storage* Storage::GetInstance(::firebase::App* app, const char* url,
if (init_result_out != nullptr) *init_result_out = kInitResultSuccess;
return it->second;
}
FIREBASE_UTIL_RETURN_NULL_IF_GOOGLE_PLAY_UNAVAILABLE(*app, init_result_out);

Storage* storage = new Storage(app, url);
if (!storage->internal_->initialized()) {
Expand Down