Skip to content

Add a workaround for an AdMob race condition to integration test. #263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 29, 2021
Merged

Add a workaround for an AdMob race condition to integration test. #263

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
789a377
Add a workaround for an AdMob race condition to integration test.
jonsimantov Jan 29, 2021
e53b2fc
Merge branch 'dev' into feature/js-admob-test-workaround
jonsimantov Jan 29, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions admob/integration_test/src/integration_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,6 +123,11 @@ void FirebaseAdMobTest::SetUpTestSuite() {
}

void FirebaseAdMobTest::TearDownTestSuite() {
// Workaround: AdMob does some of its initialization in the main
// thread, so if you terminate it too quickly after initialization
// it can cause issues. Add a small delay here in case most of the
// tests are skipped.
ProcessEvents(1000);
LogDebug("Shutdown AdMob.");
firebase::admob::Terminate();
LogDebug("Shutdown Firebase App.");
Expand Down