Skip to content

Conversation

@a-maurice
Copy link
Contributor

Description

Provide details of the change, and generalize the change in the PR title above.

It seems like gcloud is requiring Python 3.9, so update the runners to just use that consistently across.


Testing

Describe how you've tested these changes. Link any manually triggered Integration tests or CPP binary SDK Packaging Github Action workflows, if applicable.


Type of Change

Place an x the applicable box:

  • Bug fix. Add the issue # below if applicable.
  • New feature. A non-breaking change which adds functionality.
  • Other, such as a build process or documentation change.

Notes

  • Bug fixes and feature changes require an update to the Release Notes section of release_build_files/readme.md.
  • Read the contribution guidelines CONTRIBUTING.md.
  • Changes to the public API require an internal API review. If you'd like to help us make Firebase APIs better, please propose your change in a feature request so that we can discuss it together.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @a-maurice, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the Python version utilized by the GitHub Actions runners to 3.9. This change is necessary to meet the new requirements of gcloud, which now mandates Python 3.9, thereby ensuring consistent and compatible build processes across all GHA workflows.

Highlights

  • Python Version Update: The Python version used by GitHub Actions (GHA) runners has been updated from 3.8 to 3.9.
  • Gcloud Compatibility: This update ensures compatibility with gcloud, which now requires Python 3.9, standardizing the version across the build environment.
Ignored Files
  • Ignored by pattern: .github/workflows/** (9)
    • .github/workflows/checks.yml
    • .github/workflows/checks_secure.yml
    • .github/workflows/cpp-packaging.yml
    • .github/workflows/integration_tests.yml
    • .github/workflows/ios.yml
    • .github/workflows/lint.yml
    • .github/workflows/retry-test-failures.yml
    • .github/workflows/update-dependencies.yml
    • .github/workflows/update-feature-branches.yml
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@a-maurice a-maurice added the skip-release-notes Skip release notes check label Oct 22, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request updates the Python version used by GHA runners from 3.8 to 3.9 in the print_matrix_configuration.py file. This change is made to address a requirement from gcloud. I have identified a potential issue where the Python version update might not be consistently applied across all workflows, and have provided a review comment to address this.

"os": ["ubuntu-22.04", "macos-14", "windows-latest"],
"architecture": ["x64", "arm64"],
"python_version": ["3.8"],
"python_version": ["3.9"],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

Updating the Python version here, but it's crucial to ensure this change is reflected and tested across all relevant workflows that depend on Python. Verify that all workflows are compatible with Python 3.9 and that no regressions are introduced due to this update.

Consider adding a test case to specifically check the Python version used in the workflows.

Copy link
Contributor

@AustinBenoit AustinBenoit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@a-maurice a-maurice merged commit 72f627a into main Oct 22, 2025
31 of 45 checks passed
@a-maurice a-maurice deleted the am-update_python branch October 22, 2025 19:44
@github-actions github-actions bot added the tests: in-progress This PR's integration tests are in progress. label Oct 22, 2025
@github-actions
Copy link

github-actions bot commented Oct 22, 2025

✅  Integration test succeeded!

Requested by @a-maurice on commit 72f627a
Last updated: Wed Oct 22 14:43 PDT 2025
View integration test log & download artifacts

@a-maurice a-maurice restored the am-update_python branch October 22, 2025 20:46
@a-maurice a-maurice deleted the am-update_python branch October 22, 2025 20:46
@github-actions github-actions bot added the tests: succeeded This PR's integration tests succeeded. label Oct 22, 2025
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Oct 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-release-notes Skip release notes check tests: succeeded This PR's integration tests succeeded.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants