-
Notifications
You must be signed in to change notification settings - Fork 126
Update the python version used by GHA runners #1797
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @a-maurice, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the Python version utilized by the GitHub Actions runners to 3.9. This change is necessary to meet the new requirements of gcloud, which now mandates Python 3.9, thereby ensuring consistent and compatible build processes across all GHA workflows. Highlights
Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
The pull request updates the Python version used by GHA runners from 3.8 to 3.9 in the print_matrix_configuration.py file. This change is made to address a requirement from gcloud. I have identified a potential issue where the Python version update might not be consistently applied across all workflows, and have provided a review comment to address this.
| "os": ["ubuntu-22.04", "macos-14", "windows-latest"], | ||
| "architecture": ["x64", "arm64"], | ||
| "python_version": ["3.8"], | ||
| "python_version": ["3.9"], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updating the Python version here, but it's crucial to ensure this change is reflected and tested across all relevant workflows that depend on Python. Verify that all workflows are compatible with Python 3.9 and that no regressions are introduced due to this update.
Consider adding a test case to specifically check the Python version used in the workflows.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
✅ Integration test succeeded!Requested by @a-maurice on commit 72f627a |
Description
It seems like gcloud is requiring Python 3.9, so update the runners to just use that consistently across.
Testing
Type of Change
Place an
xthe applicable box:Notes
Release Notessection ofrelease_build_files/readme.md.