Skip to content

Change the GetSessionId docs to match GetAnalyticsInstanceId's phrasing. #1190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 24, 2023
Merged

Change the GetSessionId docs to match GetAnalyticsInstanceId's phrasing. #1190

merged 1 commit into from
Jan 24, 2023

Conversation

jonsimantov
Copy link
Contributor

Description

Provide details of the change, and generalize the change in the PR title above.

Testing

Describe how you've tested these changes. Link any manually triggered Integration tests or CPP binary SDK Packaging Github Action workflows, if applicable.

Type of Change

Place an x the applicable box:

  • Bug fix. Add the issue # below if applicable.
  • New feature. A non-breaking change which adds functionality.
  • Other, such as a build process or documentation change.

Notes

  • Bug fixes and feature changes require an update to the Release Notes section of release_build_files/readme.md.
  • Read the contribution guidelines CONTRIBUTING.md.
  • Changes to the public API require an internal API review. If you'd like to help us make Firebase APIs better, please propose your change in a feature request so that we can discuss it together.

@jonsimantov jonsimantov added the skip-release-notes Skip release notes check label Jan 24, 2023
@jonsimantov jonsimantov enabled auto-merge (squash) January 24, 2023 18:20
@jonsimantov jonsimantov changed the title Change the docs to match GetAnalyticsInstanceId's phrasing. Change the GetSessionId docs to match GetAnalyticsInstanceId's phrasing. Jan 24, 2023
@jonsimantov jonsimantov requested a review from a-maurice January 24, 2023 22:00
@jonsimantov jonsimantov merged commit 21f954f into main Jan 24, 2023
@github-actions github-actions bot added the tests: in-progress This PR's integration tests are in progress. label Jan 24, 2023
@github-actions
Copy link

github-actions bot commented Jan 24, 2023 •
edited
Loading

✅  Integration test succeeded!

Requested by @jonsimantov on commit 21f954f
Last updated: Tue Jan 24 15:45 PST 2023
View integration test log & download artifacts

@github-actions github-actions bot added the tests: succeeded This PR's integration tests succeeded. label Jan 24, 2023
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Jan 24, 2023
@firebase firebase locked and limited conversation to collaborators Feb 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@a-maurice a-maurice a-maurice approved these changes

Assignees

@a-maurice a-maurice

Labels
skip-release-notes Skip release notes check tests: succeeded This PR's integration tests succeeded.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jonsimantov @a-maurice