Skip to content

Clean up integration test for GetSessionId. #1188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 23, 2023
Merged

Clean up integration test for GetSessionId. #1188

merged 4 commits into from
Jan 23, 2023

Conversation

jonsimantov
Copy link
Contributor

@jonsimantov jonsimantov commented Jan 23, 2023 •
edited
Loading

Description

Provide details of the change, and generalize the change in the PR title above.

Clean up the integration test and change it to all platforms have retry on GetSessionId, as sometimes a session ID is not generated until a while after the first request.

Testing

Describe how you've tested these changes. Link any manually triggered Integration tests or CPP binary SDK Packaging Github Action workflows, if applicable.

Integration tests running in this PR.

Type of Change

Place an x the applicable box:

  • Bug fix. Add the issue # below if applicable.
  • New feature. A non-breaking change which adds functionality.
  • Other, such as a build process or documentation change.

Notes

  • Bug fixes and feature changes require an update to the Release Notes section of release_build_files/readme.md.
  • Read the contribution guidelines CONTRIBUTING.md.
  • Changes to the public API require an internal API review. If you'd like to help us make Firebase APIs better, please propose your change in a feature request so that we can discuss it together.

@jonsimantov jonsimantov requested a review from a-maurice January 23, 2023 19:08
@jonsimantov jonsimantov added the tests-requested: quick Trigger a quick set of integration tests. label Jan 23, 2023
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. and removed tests-requested: quick Trigger a quick set of integration tests. labels Jan 23, 2023
@github-actions
Copy link

github-actions bot commented Jan 23, 2023 •
edited
Loading

✅  Integration test succeeded!

Requested by @jonsimantov on commit 9c494f7
Last updated: Mon Jan 23 13:50 PST 2023
View integration test log & download artifacts

@jonsimantov jonsimantov added the tests-requested: quick Trigger a quick set of integration tests. label Jan 23, 2023
@github-actions github-actions bot removed the tests-requested: quick Trigger a quick set of integration tests. label Jan 23, 2023
@github-actions github-actions bot added the tests: succeeded This PR's integration tests succeeded. label Jan 23, 2023
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Jan 23, 2023
@jonsimantov jonsimantov added the skip-release-notes Skip release notes check label Jan 23, 2023
@jonsimantov jonsimantov enabled auto-merge (squash) January 23, 2023 20:52
@jonsimantov jonsimantov merged commit 9c494f7 into main Jan 23, 2023
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. tests: succeeded This PR's integration tests succeeded. and removed tests: succeeded This PR's integration tests succeeded. labels Jan 23, 2023
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Jan 23, 2023
@a-maurice a-maurice deleted the cleanup-analytics-test branch January 24, 2023 19:01
@firebase firebase locked and limited conversation to collaborators Feb 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@a-maurice a-maurice a-maurice approved these changes

Assignees

@a-maurice a-maurice

Labels
skip-release-notes Skip release notes check tests: succeeded This PR's integration tests succeeded.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jonsimantov @a-maurice