Skip to content

Add desktop Debug provider for App Check #1126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Dec 12, 2022
Merged

Conversation

a-maurice
Copy link
Contributor

Description

Provide details of the change, and generalize the change in the PR title above.

Add the desktop implementation of the debug provider for App Check, which uses the desktop rest implementation to retrieve a valid attestation token from the server.


Testing

Describe how you've tested these changes. Link any manually triggered Integration tests or CPP binary SDK Packaging Github Action workflows, if applicable.

Local testing


Type of Change

Place an x the applicable box:

  • Bug fix. Add the issue # below if applicable.
  • New feature. A non-breaking change which adds functionality.
  • Other, such as a build process or documentation change.

Notes

  • Bug fixes and feature changes require an update to the Release Notes section of release_build_files/readme.md.
  • Read the contribution guidelines CONTRIBUTING.md.
  • Changes to the public API require an internal API review. If you'd like to help us make Firebase APIs better, please propose your change in a feature request so that we can discuss it together.

@a-maurice a-maurice added the skip-release-notes Skip release notes check label Oct 28, 2022
@a-maurice a-maurice marked this pull request as ready for review October 28, 2022 00:41
@a-maurice a-maurice merged commit 8785d02 into main Dec 12, 2022
@a-maurice a-maurice deleted the am-app_check_desktop branch December 12, 2022 21:13
@github-actions github-actions bot added the tests: in-progress This PR's integration tests are in progress. label Dec 12, 2022
@github-actions
Copy link

github-actions bot commented Dec 12, 2022

❌  Integration test FAILED

Requested by @a-maurice on commit 8785d02
Last updated: Mon Dec 12 16:09 PST 2022
View integration test log & download artifacts

Failures Configs
firestore [TEST] [FLAKINESS] [Android] [2/3 os: ubuntu windows] [1/2 android_device: android_target]
(1 failed tests)  CRASH/TIMEOUT
gma [TEST] [FAILURE] [iOS] [macos] [1/2 ios_device: ios_target]
(2 failed tests)  FirebaseGmaTest.TestRewardedAdLoad
  FirebaseGmaTest.TestRewardedAdLoadEmptyRequest
[TEST] [FLAKINESS] [Android] [1/3 os: ubuntu] [1/2 android_device: android_target]
(2 failed tests)  FirebaseGmaTest.TestInterstitialAdStress
  FirebaseGmaTest.TestRewardedAdStress
[TEST] [FLAKINESS] [Android] [1/3 os: windows] [1/2 android_device: android_target]
(1 failed tests)  CRASH/TIMEOUT
messaging [TEST] [ERROR] [Android] [1/3 os: windows] [1/2 android_device: android_target]
storage [TEST] [FLAKINESS] [Android] [1/3 os: ubuntu] [1/2 android_device: android_target]
(1 failed tests)  CRASH/TIMEOUT

Add flaky tests to go/fpl-cpp-flake-tracker

@github-actions github-actions bot added the tests: failed This PR's integration tests failed. label Dec 13, 2022
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Dec 13, 2022
@firebase firebase locked and limited conversation to collaborators Jan 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
skip-release-notes Skip release notes check tests: failed This PR's integration tests failed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants