Remove the Firestore patch for the Windows decltype of captured lambda build error #1097
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
|
FYI: This PR has been manually cherry-picked into #1104. Close this PR once that PR is merged. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch was added for the M121 release (#1076) to get the build fixed on Windows. It patched in firebase/firebase-ios-sdk#10237. Since this fix will be included in the M122 release, there is no need to patch it in anymore. In fact, patching it in will likely cause a build error because the patch will not apply cleanly.
This PR should not be merged directly; rather, it should be patched into the PR that upgrades the dependencies on the firebase-ios-sdk.