Skip to content

Update Android Emulators #1063

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 30, 2022
Merged

Update Android Emulators #1063

merged 4 commits into from
Aug 30, 2022

Conversation

sunmou99
Copy link
Contributor

@sunmou99 sunmou99 commented Aug 30, 2022 •
edited
Loading

Description

emulator_target device is quite flaky. Update the emulator been used.

Testing

Describe how you've tested these changes. Link any manually triggered Integration tests or CPP binary SDK Packaging Github Action workflows, if applicable.

Type of Change

Place an x the applicable box:

  • Bug fix. Add the issue # below if applicable.
  • New feature. A non-breaking change which adds functionality.
  • Other, such as a build process or documentation change.

Notes

  • Bug fixes and feature changes require an update to the Release Notes section of release_build_files/readme.md.
  • Read the contribution guidelines CONTRIBUTING.md.
  • Changes to the public API require an internal API review. If you'd like to help us make Firebase APIs better, please propose your change in a feature request so that we can discuss it together.

@sunmou99 sunmou99 added the tests-requested: full Trigger a FULL set of integration tests (uses expanded test matrix). label Aug 30, 2022
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. and removed tests-requested: full Trigger a FULL set of integration tests (uses expanded test matrix). labels Aug 30, 2022
@github-actions
Copy link

github-actions bot commented Aug 30, 2022 •
edited
Loading

❌  Integration test FAILED

Requested by @sunmou99 on commit e3a8a98
Last updated: Tue Aug 30 17:04 PDT 2022
View integration test log & download artifacts

Failures Configs
admob [BUILD] [ERROR] [Android] [1/3 os: windows]
analytics [BUILD] [ERROR] [Android] [1/3 os: windows]
firestore
(4 items)[TEST] [FAILURE] [iOS] [macos] [1/2 ios_device: simulator_target]
(1 failed tests)  NumericTransformsTest.CreateDocumentWithIncrement
[TEST] [FAILURE] [tvOS] [macos] [tvos_simulator]
(1 failed tests)  CleanupTest.DocumentChangeIsBlankAfterCleanup
[TEST] [FLAKINESS] [Android] [1/3 os: ubuntu] [1/2 android_device: android_target]
(1 failed tests)  ServerTimestampTest.TestServerTimestampsUsesPreviousValueFromLocalMutation
[TEST] [FLAKINESS] [iOS] [macos] [1/2 ios_device: ios_target]
(1 failed tests)  CRASH/TIMEOUT

Add flaky tests to go/fpl-cpp-flake-tracker

@sunmou99 sunmou99 changed the title Update Android Emulators. Update Android Emulators Aug 30, 2022
@sunmou99 sunmou99 added the tests-requested: quick Trigger a quick set of integration tests. label Aug 30, 2022
@github-actions github-actions bot removed the tests-requested: quick Trigger a quick set of integration tests. label Aug 30, 2022
@sunmou99 sunmou99 added the tests-requested: full Trigger a FULL set of integration tests (uses expanded test matrix). label Aug 30, 2022
@github-actions github-actions bot added tests: failed This PR's integration tests failed. and removed tests-requested: full Trigger a FULL set of integration tests (uses expanded test matrix). labels Aug 30, 2022
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Aug 30, 2022
@sunmou99 sunmou99 requested a review from jonsimantov August 30, 2022 17:25
jonsimantov
jonsimantov reviewed Aug 30, 2022
View reviewed changes
scripts/gha/test_simulator.py
@@ -745,7 +745,7 @@ def _run_android_test(testapp_dir, package_name, app_path, helper_project, max_a
_uninstall_android_app(package_name)

result = test_validation.validate_results(log, test_validation.CPP)
if result.complete and (FLAGS.test_type != "uitest" or result.fails == 0):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does this line fix?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Retry if some tests failed or the log is incomplete.
Previously, only retry if the test log is incomplete.

@jonsimantov jonsimantov self-requested a review August 30, 2022 18:14
@sunmou99 sunmou99 added skip-release-notes Skip release notes check and removed tests: failed This PR's integration tests failed. labels Aug 30, 2022
@sunmou99 sunmou99 merged commit e3a8a98 into main Aug 30, 2022
@sunmou99 sunmou99 deleted the bugfix/android-emulator branch August 30, 2022 20:44
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. tests: failed This PR's integration tests failed. labels Aug 30, 2022
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Aug 31, 2022
@firebase firebase locked and limited conversation to collaborators Sep 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jonsimantov jonsimantov jonsimantov approved these changes

Assignees
No one assigned
Labels
skip-release-notes Skip release notes check tests: failed This PR's integration tests failed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sunmou99 @jonsimantov