Skip to content

Update release version to 9.4.0 #1050

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 9, 2022
Merged

Update release version to 9.4.0 #1050

merged 1 commit into from
Aug 9, 2022

Conversation

DellaBitta
Copy link
Contributor

@DellaBitta DellaBitta commented Aug 8, 2022 •
edited
Loading

Description

Provide details of the change, and generalize the change in the PR title above.

Updates the release version to 9.4.0 in release_build_files/readme.md and in cpp_sdk_version.json.

Testing

Describe how you've tested these changes. Link any manually triggered Integration tests or CPP binary SDK Packaging Github Action workflows, if applicable.

Type of Change

Place an x the applicable box:

  • Bug fix. Add the issue # below if applicable.
  • New feature. A non-breaking change which adds functionality.
  • Other, such as a build process or documentation change.

@DellaBitta DellaBitta marked this pull request as ready for review August 8, 2022 21:42
@DellaBitta DellaBitta requested a review from jonsimantov August 8, 2022 21:44
@DellaBitta DellaBitta merged commit ba72597 into main Aug 9, 2022
@DellaBitta DellaBitta deleted the feature/update_release_version branch August 9, 2022 01:12
@github-actions github-actions bot added the tests: in-progress This PR's integration tests are in progress. label Aug 9, 2022
@github-actions
Copy link

github-actions bot commented Aug 9, 2022 •
edited
Loading

Integration test with FLAKINESS (succeeded after retry)

Requested by @DellaBitta on commit ba72597
Last updated: Tue Aug 9 08:54 PDT 2022
View integration test log & download artifacts

Failures Configs
auth [TEST] [FLAKINESS] [iOS] [macos] [1/2 ios_device: ios_target]
(1 failed tests)  FirebaseAuthTest.TestSignInWithBadPasswordFails
gma [TEST] [FLAKINESS] [Android] [1/3 os: macos] [1/2 android_device: android_target]
(1 failed tests)  FirebaseGmaTest.TestAdViewLoadAdInlineAdaptiveAd

Add flaky tests to go/fpl-cpp-flake-tracker

@github-actions github-actions bot added the tests: failed This PR's integration tests failed. label Aug 9, 2022
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Aug 9, 2022
@github-actions github-actions bot added the tests: succeeded This PR's integration tests succeeded. label Aug 9, 2022
@firebase firebase locked and limited conversation to collaborators Sep 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@a-maurice a-maurice a-maurice approved these changes

@jonsimantov jonsimantov Awaiting requested review from jonsimantov

Assignees
No one assigned
Labels
tests: failed This PR's integration tests failed. tests: succeeded This PR's integration tests succeeded.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DellaBitta @a-maurice