Skip to content

Firestore: Improve logging of timeouts in integration tests #1030

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Jul 27, 2022
Merged

Firestore: Improve logging of timeouts in integration tests #1030

merged 10 commits into from
Jul 27, 2022

Conversation

dconeybe
Copy link
Contributor

Add several usages of googletest's SCOPED_TRACE macro to help debug timeouts in tests. This is specifically targeted at debugging the flaky test NumericTransformsTest.CreateDocumentWithIncrement, which often times out but it is unclear what step of the test timed out.

This PR also adds the new Stopwatch class, which is used by methods that report timeouts to include the elapsed time in the timeout message. This will also help debug timeouts by knowing exactly how much time elapsed.

@dconeybe dconeybe added api: firestore skip-release-notes Skip release notes check labels Jul 18, 2022
@dconeybe dconeybe self-assigned this Jul 18, 2022
@dconeybe dconeybe added the tests-requested: quick Trigger a quick set of integration tests. label Jul 18, 2022
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. and removed tests-requested: quick Trigger a quick set of integration tests. labels Jul 18, 2022
@github-actions
Copy link

github-actions bot commented Jul 18, 2022 •
edited
Loading

Integration test with FLAKINESS (succeeded after retry)

Requested by @dconeybe on commit ef7dff1
Last updated: Wed Jul 27 11:41 PDT 2022
View integration test log & download artifacts

Failures Configs
firestore [TEST] [FLAKINESS] [Android] [2/3 os: windows macos] [1/2 android_device: android_target]
(1 failed tests)  CRASH/TIMEOUT

Add flaky tests to go/fpl-cpp-flake-tracker

@github-actions github-actions bot added the tests: failed This PR's integration tests failed. label Jul 18, 2022
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Jul 18, 2022
@dconeybe dconeybe added the tests-requested: quick Trigger a quick set of integration tests. label Jul 18, 2022
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. tests: failed This PR's integration tests failed. and removed tests-requested: quick Trigger a quick set of integration tests. tests: failed This PR's integration tests failed. labels Jul 18, 2022
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Jul 19, 2022
@dconeybe dconeybe added the tests-requested: quick Trigger a quick set of integration tests. label Jul 19, 2022
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. tests: failed This PR's integration tests failed. and removed tests-requested: quick Trigger a quick set of integration tests. tests: failed This PR's integration tests failed. labels Jul 19, 2022
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Jul 19, 2022
@dconeybe dconeybe removed the tests: failed This PR's integration tests failed. label Jul 19, 2022
@dconeybe dconeybe added the tests-requested: quick Trigger a quick set of integration tests. label Jul 19, 2022
@github-actions github-actions bot added the tests: succeeded This PR's integration tests succeeded. label Jul 20, 2022
@dconeybe dconeybe removed the tests: failed This PR's integration tests failed. label Jul 20, 2022
@dconeybe dconeybe requested a review from ehsannas July 20, 2022 01:44
@dconeybe dconeybe added tests-requested: quick Trigger a quick set of integration tests. and removed tests: succeeded This PR's integration tests succeeded. labels Jul 24, 2022
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. tests: failed This PR's integration tests failed. and removed tests-requested: quick Trigger a quick set of integration tests. labels Jul 24, 2022
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Jul 24, 2022
@github-actions github-actions bot added the tests: succeeded This PR's integration tests succeeded. label Jul 25, 2022
@dconeybe dconeybe removed the tests: failed This PR's integration tests failed. label Jul 25, 2022
@dconeybe dconeybe requested review from wu-hui and removed request for ehsannas July 25, 2022 13:50
@dconeybe dconeybe assigned wu-hui and unassigned ehsannas Jul 25, 2022
wu-hui
wu-hui approved these changes Jul 27, 2022
View reviewed changes
@wu-hui wu-hui removed their assignment Jul 27, 2022
@dconeybe dconeybe enabled auto-merge (squash) July 27, 2022 15:44
wu-hui
wu-hui approved these changes Jul 27, 2022
View reviewed changes
Copy link
Contributor

@wu-hui wu-hui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve again.

@dconeybe dconeybe merged commit ef7dff1 into main Jul 27, 2022
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. and removed tests: succeeded This PR's integration tests succeeded. labels Jul 27, 2022
@dconeybe dconeybe deleted the dconeybe/NumericTransformsTestImprovedTimeoutLogging branch July 27, 2022 17:02
@github-actions github-actions bot added the tests: succeeded This PR's integration tests succeeded. label Jul 27, 2022
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Jul 27, 2022
@firebase firebase locked and limited conversation to collaborators Aug 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wu-hui wu-hui wu-hui approved these changes

Assignees

@dconeybe dconeybe

Labels
api: firestore skip-release-notes Skip release notes check tests: succeeded This PR's integration tests succeeded.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dconeybe @wu-hui @ehsannas