Skip to content

Conversation

rlazo
Copy link
Collaborator

@rlazo rlazo commented May 23, 2024

Their versioning doesn't respect semver

Their versioning doesn't respect semver
@rlazo rlazo requested review from daymxn and emilypgoogle May 23, 2024 16:12
Copy link
Contributor

github-actions bot commented May 23, 2024

📝 PRs merging into main branch

Our main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released.

Copy link
Contributor

buildSrc Test Results

37 tests   37 ✔️  59s ⏱️
  8 suites    0 💤
  8 files      0

Results for commit c9d26ba.

@rlazo rlazo merged commit 7083215 into master May 23, 2024
@rlazo rlazo deleted the rl.pom.validator.listenablefuture branch May 23, 2024 16:15
@google-oss-bot
Copy link
Contributor

@google-oss-bot
Copy link
Contributor

Coverage Report 1

Affected Products

  • firebase-firestore

    Overall coverage changed from 44.76% (b7a998f) to 44.77% (a9bfcf9) by +0.02%.

    FilenameBase (b7a998f)Merge (a9bfcf9)Diff
    DeleteMutation.java90.48%95.24%+4.76%
    LruGarbageCollector.java93.64%97.27%+3.64%
    SetMutation.java97.22%94.44%-2.78%
  • firebase-installations

    Overall coverage changed from ? (b7a998f) to 58.68% (a9bfcf9) by ?.

    23 individual files with coverage change

    FilenameBase (b7a998f)Merge (a9bfcf9)Diff
    AutoValue_InstallationResponse.java?58.93%?
    AutoValue_PersistedInstallationEntry.java?61.18%?
    AutoValue_TokenResult.java?45.65%?
    AwaitListener.java?0.00%?
    Clock.java?0.00%?
    CrossProcessLock.java?51.85%?
    FirebaseInstallations.java?96.62%?
    FirebaseInstallationServiceClient.java?4.80%?
    FirebaseInstallationsException.java?78.57%?
    FirebaseInstallationsRegistrar.java?100.00%?
    GetAuthTokenListener.java?100.00%?
    GetIdListener.java?70.00%?
    IidStore.java?22.39%?
    InstallationResponse.java?100.00%?
    Installations.kt?40.00%?
    PersistedInstallation.java?97.01%?
    PersistedInstallationEntry.java?100.00%?
    RandomFidGenerator.java?20.00%?
    RequestLimiter.java?100.00%?
    StateListener.java?0.00%?
    SystemClock.java?100.00%?
    TokenResult.java?100.00%?
    Utils.java?95.00%?

  • firebase-messaging

    Overall coverage changed from 84.26% (b7a998f) to 84.18% (a9bfcf9) by -0.07%.

    FilenameBase (b7a998f)Merge (a9bfcf9)Diff
    RequestDeduplicator.java90.00%80.00%-10.00%
  • firebase-storage

    Overall coverage changed from 84.08% (b7a998f) to 84.29% (a9bfcf9) by +0.21%.

    FilenameBase (b7a998f)Merge (a9bfcf9)Diff
    StorageTask.java83.69%83.99%+0.30%
    StreamDownloadTask.java88.89%88.41%-0.48%
    UploadTask.java81.52%83.17%+1.65%

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/DJ84f63PVi.html

@google-oss-bot
Copy link
Contributor

Startup Time Report 1

The report is too large (122,571 chars) to be displayed on GitHub. Please check this report on GCS.

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/XHffqrK596/index.html

@firebase firebase locked and limited conversation to collaborators Jun 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants