Skip to content

Collect, persist and transport ANR ApplicationExitInfo #2643

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tejasd merged 26 commits into from
May 14, 2021
Merged

Collect, persist and transport ANR ApplicationExitInfo #2643

tejasd merged 26 commits into from
May 14, 2021

Conversation

@tejasd
Copy link
Contributor

@tejasd tejasd commented May 4, 2021

No description provided.

tejasd added 21 commits April 13, 2021 15:49
@tejasd
Add collectAnrs to FeatureSettings
90322b3
@tejasd
Add unit test to test settings received when anr collection is enabled
4e186a6
@tejasd
Cleanup json file
62e8c18
@tejasd
Add ability to get the startTimestampMs of a session
eb08e6b
@tejasd
Merge branch 'crashlytics/anrs' into td/anr-2
ec3e5c9
@tejasd
Change Long to long
c5f5f26
@tejasd
Merge branch 'crashlytics/anrs' into td/anr
4d68ae4
@tejasd
Add ApplicationExitInfo to CrashlyticsReport
0422970
@tejasd
Comment cleanup
b928e3f
@tejasd
Revert makeEvents refactoring
20b4f30
@tejasd
More cleanup
2c8f5a9
@tejasd
Merge branch 'crashlytics/anrs' into td/anr
b0f9cc4
@tejasd
Merge branch 'crashlytics/anrs' into td/anr
3a56029
@tejasd
Merge branch 'crashlytics/anrs' into td/anr-2
3452ee4
@tejasd
AppExitInfo json transform
d1eeea8
@tejasd
Merge branch 'crashlytics/anrs' into td/anr-2
490733e
@tejasd
Merge branch 'crashlytics/anrs' into td/anr
5bb61f5
@tejasd
AppExitInfo json transform
1047983
@tejasd
Merge branch 'crashlytics/anrs' into td/anr-2
47511bc
@tejasd
Merge branch 'td/anr-2' into td/anr
76f8438
@tejasd
Collect and Persist ANRs + robolectric tests fpr CrashlyticsControlle…
2e17dee 
…r and SessionReportingCoordinator
@googlebot googlebot added the cla: yes Override cla label May 4, 2021
@google-oss-bot
Copy link
Contributor

google-oss-bot commented May 4, 2021 •
edited
Loading

Coverage Report

Affected SDKs

  • firebase-crashlytics

    SDK overall coverage changed from 0.00% (c81f83c) to 8.13% (0e7d206d) by +8.13%.

    Click to show coverage changes in 19 files.
    Filename Base (c81f83c) Head (0e7d206d) Diff
    AppData.java 0.00% 56.25% +56.25%
    AutoCrashlyticsReportEncoder.java 0.00% 58.09% +58.09%
    AutoValue_CrashlyticsReport_ApplicationExitInfo.java 0.00% 67.19% +67.19%
    CLSUUID.java 0.00% 77.55% +77.55%
    CommonUtils.java 0.00% 0.94% +0.94%
    CrashlyticsBackgroundWorker.java 0.00% 56.25% +56.25%
    CrashlyticsController.java 0.00% 13.60% +13.60%
    CrashlyticsFileMarker.java 0.00% 30.77% +30.77%
    CrashlyticsReport.java 0.00% 2.80% +2.80%
    CrashlyticsReportDataCapture.java 0.00% 4.35% +4.35%
    CrashlyticsReportJsonTransform.java 0.00% 1.27% +1.27%
    CrashlyticsReportPersistence.java 0.00% 2.26% +2.26%
    DataTransportCrashlyticsReportSender.java 0.00% 38.89% +38.89%
    FeaturesSettingsData.java 0.00% 100.00% +100.00%
    IdManager.java 0.00% 3.13% +3.13%
    LogFileManager.java 0.00% 2.17% +2.17%
    Logger.java 0.00% 43.24% +43.24%
    ProviderProxyNativeComponent.java 0.00% 16.28% +16.28%
    SessionReportingCoordinator.java 0.00% 33.59% +33.59%

  • firebase-database

    SDK overall coverage changed from 49.99% (c81f83c) to 50.10% (0e7d206d) by +0.11%.

    Filename Base (c81f83c) Head (0e7d206d) Diff
    DoubleNode.java 88.24% 100.00% +11.76%
    WebsocketConnection.java 32.77% 37.29% +4.52%

  • firebase-firestore

    SDK overall coverage changed from 47.14% (c81f83c) to 47.23% (0e7d206d) by +0.09%.

    Filename Base (c81f83c) Head (0e7d206d) Diff
    AsyncQueue.java 77.89% 78.39% +0.50%
    FirestoreClient.java 30.08% 34.96% +4.88%
    LruGarbageCollector.java 84.11% 93.46% +9.35%

  • firebase-messaging

    SDK overall coverage changed from 83.56% (c81f83c) to 83.15% (0e7d206d) by -0.41%.

    Filename Base (c81f83c) Head (0e7d206d) Diff
    TopicsSubscriber.java 91.38% 88.79% -2.59%
    TopicsSyncTask.java 53.33% 49.33% -4.00%

  • firebase-storage

    SDK overall coverage changed from 85.85% (c81f83c) to 85.76% (0e7d206d) by -0.09%.

    Filename Base (c81f83c) Head (0e7d206d) Diff
    StreamDownloadTask.java 88.89% 88.41% -0.48%
    UploadTask.java 80.58% 80.22% -0.36%

Test Logs

Notes

HTML coverage reports can be produced locally with ./gradlew <product>:checkCoverage.
Report files are located at <product-build-dir>/reports/jacoco/.

Head commit (0e7d206d) is created by Prow via merging commits: c81f83c dbc72dc.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented May 4, 2021 •
edited
Loading

Binary Size Report

Affected SDKs

  • firebase-abt

    Type Base (c81f83c) Head (0e7d206d) Diff
    aar ? 13.7 kB ? (?)
    apk (aggressive) ? 78.4 kB ? (?)
    apk (release) ? 641 kB ? (?)

  • firebase-annotations

    Type Base (c81f83c) Head (0e7d206d) Diff
    apk (aggressive) ? 8.39 kB ? (?)
    apk (release) ? 8.77 kB ? (?)

  • firebase-appcheck

    Type Base (c81f83c) Head (0e7d206d) Diff
    aar ? 33.2 kB ? (?)
    apk (aggressive) ? 284 kB ? (?)
    apk (release) ? 935 kB ? (?)

  • firebase-appcheck-debug

    Type Base (c81f83c) Head (0e7d206d) Diff
    aar ? 10.8 kB ? (?)
    apk (aggressive) ? 284 kB ? (?)
    apk (release) ? 938 kB ? (?)

  • firebase-appcheck-debug-testing

    Type Base (c81f83c) Head (0e7d206d) Diff
    aar ? 6.40 kB ? (?)
    apk (aggressive) ? 286 kB ? (?)
    apk (release) ? 972 kB ? (?)

  • firebase-appcheck-interop

    Type Base (c81f83c) Head (0e7d206d) Diff
    aar ? 5.17 kB ? (?)
    apk (aggressive) ? 281 kB ? (?)
    apk (release) ? 925 kB ? (?)

  • firebase-appcheck-safetynet

    Type Base (c81f83c) Head (0e7d206d) Diff
    aar ? 11.4 kB ? (?)
    apk (aggressive) ? 285 kB ? (?)
    apk (release) ? 947 kB ? (?)

  • firebase-common

    Type Base (c81f83c) Head (0e7d206d) Diff
    aar ? 45.5 kB ? (?)
    apk (aggressive) ? 77.8 kB ? (?)
    apk (release) ? 635 kB ? (?)

  • firebase-common-ktx

    Type Base (c81f83c) Head (0e7d206d) Diff
    aar ? 5.98 kB ? (?)
    apk (aggressive) ? 93.4 kB ? (?)
    apk (release) ? 1.11 MB ? (?)

  • firebase-components

    Type Base (c81f83c) Head (0e7d206d) Diff
    aar ? 41.4 kB ? (?)
    apk (aggressive) ? 8.68 kB ? (?)
    apk (release) ? 29.4 kB ? (?)

  • firebase-config

    Type Base (c81f83c) Head (0e7d206d) Diff
    aar ? 62.6 kB ? (?)
    apk (aggressive) ? 91.1 kB ? (?)
    apk (release) ? 719 kB ? (?)

  • firebase-config-ktx

    Type Base (c81f83c) Head (0e7d206d) Diff
    aar ? 5.84 kB ? (?)
    apk (aggressive) ? 111 kB ? (?)
    apk (release) ? 1.20 MB ? (?)

  • firebase-crashlytics

    Type Base (c81f83c) Head (0e7d206d) Diff
    aar ? 328 kB ? (?)
    apk (aggressive) ? 196 kB ? (?)
    apk (release) ? 824 kB ? (?)

  • firebase-crashlytics-ktx

    Type Base (c81f83c) Head (0e7d206d) Diff
    aar ? 6.55 kB ? (?)
    apk (aggressive) ? 211 kB ? (?)
    apk (release) ? 1.30 MB ? (?)

  • firebase-crashlytics-ndk

    Type Base (c81f83c) Head (0e7d206d) Diff
    aar ? 1.72 MB ? (?)
    apk (aggressive) ? 4.48 MB ? (?)
    apk (release) ? 5.11 MB ? (?)

  • firebase-database

    Type Base (c81f83c) Head (0e7d206d) Diff
    aar ? 490 kB ? (?)
    apk (aggressive) ? 283 kB ? (?)
    apk (release) ? 1.10 MB ? (?)

  • firebase-database-collection

    Type Base (c81f83c) Head (0e7d206d) Diff
    aar ? 33.8 kB ? (?)
    apk (aggressive) ? 268 kB ? (?)
    apk (release) ? 901 kB ? (?)

  • firebase-database-ktx

    Type Base (c81f83c) Head (0e7d206d) Diff
    aar ? 7.42 kB ? (?)
    apk (aggressive) ? 303 kB ? (?)
    apk (release) ? 1.58 MB ? (?)

  • firebase-datatransport

    Type Base (c81f83c) Head (0e7d206d) Diff
    aar ? 4.74 kB ? (?)
    apk (aggressive) ? 113 kB ? (?)
    apk (release) ? 704 kB ? (?)

  • firebase-decoders-json

    Type Base (c81f83c) Head (0e7d206d) Diff
    aar ? 7.52 kB ? (?)
    apk (aggressive) ? 8.68 kB ? (?)
    apk (release) ? 15.2 kB ? (?)

  • firebase-dynamic-links

    Type Base (c81f83c) Head (0e7d206d) Diff
    aar ? 51.8 kB ? (?)
    apk (aggressive) ? 307 kB ? (?)
    apk (release) ? 936 kB ? (?)

  • firebase-dynamic-links-ktx

    Type Base (c81f83c) Head (0e7d206d) Diff
    aar ? 8.51 kB ? (?)
    apk (aggressive) ? 327 kB ? (?)
    apk (release) ? 1.42 MB ? (?)

  • firebase-dynamic-module-support

    Type Base (c81f83c) Head (0e7d206d) Diff
    aar ? 5.55 kB ? (?)
    apk (aggressive) ? 138 kB ? (?)
    apk (release) ? 745 kB ? (?)

  • firebase-encoders

    Type Base (c81f83c) Head (0e7d206d) Diff
    apk (aggressive) ? 8.68 kB ? (?)
    apk (release) ? 15.3 kB ? (?)

  • firebase-encoders-json

    Type Base (c81f83c) Head (0e7d206d) Diff
    aar ? 10.7 kB ? (?)
    apk (aggressive) ? 8.68 kB ? (?)
    apk (release) ? 20.1 kB ? (?)

  • firebase-encoders-proto

    Type Base (c81f83c) Head (0e7d206d) Diff
    apk (aggressive) ? 8.68 kB ? (?)
    apk (release) ? 21.5 kB ? (?)

  • firebase-encoders-reflective

    Type Base (c81f83c) Head (0e7d206d) Diff
    aar ? 7.63 kB ? (?)
    apk (aggressive) ? 8.68 kB ? (?)
    apk (release) ? 22.1 kB ? (?)

  • firebase-firestore

    Type Base (c81f83c) Head (0e7d206d) Diff
    aar ? 1.03 MB ? (?)
    apk (aggressive) ? 438 kB ? (?)
    apk (release) ? 3.19 MB ? (?)

  • firebase-firestore-ktx

    Type Base (c81f83c) Head (0e7d206d) Diff
    aar ? 7.18 kB ? (?)
    apk (aggressive) ? 454 kB ? (?)
    apk (release) ? 3.67 MB ? (?)

  • firebase-functions

    Type Base (c81f83c) Head (0e7d206d) Diff
    aar ? 25.5 kB ? (?)
    apk (aggressive) ? 350 kB ? (?)
    apk (release) ? 1.17 MB ? (?)

  • firebase-functions-ktx

    Type Base (c81f83c) Head (0e7d206d) Diff
    aar ? 5.85 kB ? (?)
    apk (aggressive) ? 370 kB ? (?)
    apk (release) ? 1.65 MB ? (?)

  • firebase-inappmessaging

    Type Base (c81f83c) Head (0e7d206d) Diff
    aar ? 469 kB ? (?)
    apk (aggressive) ? 632 kB ? (?)
    apk (release) ? 3.32 MB ? (?)

  • firebase-inappmessaging-display

    Type Base (c81f83c) Head (0e7d206d) Diff
    aar ? 203 kB ? (?)
    apk (aggressive) ? 1.44 MB ? (?)
    apk (release) ? 4.56 MB ? (?)

  • firebase-inappmessaging-display-ktx

    Type Base (c81f83c) Head (0e7d206d) Diff
    aar ? 22.2 kB ? (?)
    apk (aggressive) ? 1.46 MB ? (?)
    apk (release) ? 5.05 MB ? (?)

  • firebase-inappmessaging-ktx

    Type Base (c81f83c) Head (0e7d206d) Diff
    aar ? 5.28 kB ? (?)
    apk (aggressive) ? 648 kB ? (?)
    apk (release) ? 3.80 MB ? (?)

  • firebase-installations

    Type Base (c81f83c) Head (0e7d206d) Diff
    aar ? 54.6 kB ? (?)
    apk (aggressive) ? 79.5 kB ? (?)
    apk (release) ? 658 kB ? (?)

  • firebase-installations-interop

    Type Base (c81f83c) Head (0e7d206d) Diff
    aar ? 8.06 kB ? (?)
    apk (aggressive) ? 55.4 kB ? (?)
    apk (release) ? 607 kB ? (?)

  • firebase-installations-ktx

    Type Base (c81f83c) Head (0e7d206d) Diff
    aar ? 4.98 kB ? (?)
    apk (aggressive) ? 95.4 kB ? (?)
    apk (release) ? 1.13 MB ? (?)

  • firebase-messaging

    Type Base (c81f83c) Head (0e7d206d) Diff
    aar ? 170 kB ? (?)
    apk (aggressive) ? 498 kB ? (?)
    apk (release) ? 2.44 MB ? (?)

  • firebase-messaging-directboot

    Type Base (c81f83c) Head (0e7d206d) Diff
    aar ? 10.1 kB ? (?)
    apk (aggressive) ? 413 kB ? (?)
    apk (release) ? 2.33 MB ? (?)

  • firebase-messaging-ktx

    Type Base (c81f83c) Head (0e7d206d) Diff
    aar ? 6.60 kB ? (?)
    apk (aggressive) ? 514 kB ? (?)
    apk (release) ? 2.92 MB ? (?)

  • firebase-ml-modeldownloader

    Type Base (c81f83c) Head (0e7d206d) Diff
    aar ? 86.9 kB ? (?)
    apk (aggressive) ? 129 kB ? (?)
    apk (release) ? 791 kB ? (?)

  • firebase-ml-modeldownloader-ktx

    Type Base (c81f83c) Head (0e7d206d) Diff
    aar ? 6.39 kB ? (?)
    apk (aggressive) ? 145 kB ? (?)
    apk (release) ? 1.27 MB ? (?)

  • firebase-perf

    Type Base (c81f83c) Head (0e7d206d) Diff
    aar ? 296 kB ? (?)
    apk (aggressive) ? 968 kB ? (?)
    apk (release) ? 2.43 MB ? (?)

  • firebase-perf-ktx

    Type Base (c81f83c) Head (0e7d206d) Diff
    aar ? 19.5 kB ? (?)
    apk (aggressive) ? 984 kB ? (?)
    apk (release) ? 2.91 MB ? (?)

  • firebase-segmentation

    Type Base (c81f83c) Head (0e7d206d) Diff
    aar ? 20.2 kB ? (?)
    apk (aggressive) ? 83.6 kB ? (?)
    apk (release) ? 697 kB ? (?)

  • firebase-storage

    Type Base (c81f83c) Head (0e7d206d) Diff
    aar ? 115 kB ? (?)
    apk (aggressive) ? 282 kB ? (?)
    apk (release) ? 965 kB ? (?)

  • firebase-storage-ktx

    Type Base (c81f83c) Head (0e7d206d) Diff
    aar ? 7.01 kB ? (?)
    apk (aggressive) ? 302 kB ? (?)
    apk (release) ? 1.45 MB ? (?)

  • protolite-well-known-types

    Type Base (c81f83c) Head (0e7d206d) Diff
    aar ? 993 kB ? (?)
    apk (aggressive) ? 134 kB ? (?)
    apk (release) ? 661 kB ? (?)

  • transport-api

    Type Base (c81f83c) Head (0e7d206d) Diff
    aar ? 6.57 kB ? (?)
    apk (aggressive) ? 8.68 kB ? (?)
    apk (release) ? 14.8 kB ? (?)

  • transport-backend-cct

    Type Base (c81f83c) Head (0e7d206d) Diff
    aar ? 53.5 kB ? (?)
    apk (aggressive) ? 47.4 kB ? (?)
    apk (release) ? 87.6 kB ? (?)

  • transport-runtime

    Type Base (c81f83c) Head (0e7d206d) Diff
    aar ? 149 kB ? (?)
    apk (aggressive) ? 33.1 kB ? (?)
    apk (release) ? 63.7 kB ? (?)

Test Logs

Notes

Head commit (0e7d206d) is created by Prow via merging commits: c81f83c dbc72dc.

@tejasd tejasd changed the title Collect and Persist ANR ApplicationExitInfo Collect, persist and transport ANR ApplicationExitInfo May 4, 2021
@tejasd tejasd requested a review from mrichards May 5, 2021 13:54
@tejasd tejasd requested a review from vywoo May 5, 2021 13:54
vywoo
vywoo reviewed May 7, 2021
View reviewed changes
Copy link

@vywoo vywoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I mostly looked at the persistance logic and everything looks good!

Base automatically changed from td/anr-2 to crashlytics/anrs May 11, 2021 19:04
@tejasd tejasd merged commit 3ee312f into crashlytics/anrs May 14, 2021
@tejasd tejasd deleted the td/anr branch May 14, 2021 18:00
@google-oss-bot
Copy link
Contributor

google-oss-bot commented May 14, 2021

@tejasd: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
check-changed dbc72dc link /test check-changed
device-check-changed dbc72dc link /test device-check-changed
macrobenchmark dbc72dc link /test macrobenchmark
Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@firebase firebase locked and limited conversation to collaborators Jun 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@mrichards mrichards Awaiting requested review from mrichards

1 more reviewer

@vywoo vywoo vywoo left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes Override cla size/XL

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tejasd @google-oss-bot @vywoo @googlebot