Skip to content

Add JSON parsing/transformation for AppExitInfo #2623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tejasd merged 16 commits into from
May 11, 2021
Merged

Add JSON parsing/transformation for AppExitInfo #2623

tejasd merged 16 commits into from
May 11, 2021

Conversation

@tejasd
Copy link
Contributor

@tejasd tejasd commented Apr 26, 2021

No description provided.

@google-cla google-cla bot added the cla: yes Override cla label Apr 26, 2021
@tejasd tejasd changed the base branch from crashlytics/anrs to master April 26, 2021 17:32
@tejasd tejasd changed the base branch from master to crashlytics/anrs April 26, 2021 17:32
@tejasd tejasd requested review from mrichards and vywoo April 26, 2021 17:34
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Apr 26, 2021 •
edited
Loading

Coverage Report

Affected SDKs

  • firebase-crashlytics

    SDK overall coverage changed from ? (ca1ab42) to 0.00% (984758a8) by ?.

    Click to show coverage changes in 110 files.
    Filename Base (ca1ab42) Head (984758a8) Diff
    AnalyticsDeferredProxy.java ? 0.00% ?
    AnalyticsEventLogger.java ? 0.00% ?
    AnalyticsEventReceiver.java ? 0.00% ?
    AppData.java ? 0.00% ?
    AppRequestData.java ? 0.00% ?
    AppSettingsData.java ? 0.00% ?
    AutoCrashlyticsReportEncoder.java ? 0.00% ?
    AutoValue_CrashlyticsReport.java ? 0.00% ?
    AutoValue_CrashlyticsReportWithSessionId.java ? 0.00% ?
    AutoValue_CrashlyticsReport_ApplicationExitInfo.java ? 0.00% ?
    AutoValue_CrashlyticsReport_CustomAttribute.java ? 0.00% ?
    AutoValue_CrashlyticsReport_FilesPayload.java ? 0.00% ?
    AutoValue_CrashlyticsReport_FilesPayload_File.java ? 0.00% ?
    AutoValue_CrashlyticsReport_Session.java ? 0.00% ?
    AutoValue_CrashlyticsReport_Session_Application.java ? 0.00% ?
    AutoValue_CrashlyticsReport_Session_Application_Organization.java ? 0.00% ?
    AutoValue_CrashlyticsReport_Session_Device.java ? 0.00% ?
    AutoValue_CrashlyticsReport_Session_Event.java ? 0.00% ?
    AutoValue_CrashlyticsReport_Session_Event_Application.java ? 0.00% ?
    AutoValue_CrashlyticsReport_Session_Event_Application_Execution.java ? 0.00% ?
    AutoValue_CrashlyticsReport_Session_Event_Application_Execution_BinaryImage.java ? 0.00% ?
    AutoValue_CrashlyticsReport_Session_Event_Application_Execution_Exception.java ? 0.00% ?
    AutoValue_CrashlyticsReport_Session_Event_Application_Execution_Signal.java ? 0.00% ?
    AutoValue_CrashlyticsReport_Session_Event_Application_Execution_Thread.java ? 0.00% ?
    AutoValue_CrashlyticsReport_Session_Event_Application_Execution_Thread_Frame.java ? 0.00% ?
    AutoValue_CrashlyticsReport_Session_Event_Device.java ? 0.00% ?
    AutoValue_CrashlyticsReport_Session_Event_Log.java ? 0.00% ?
    AutoValue_CrashlyticsReport_Session_OperatingSystem.java ? 0.00% ?
    AutoValue_CrashlyticsReport_Session_User.java ? 0.00% ?
    BackgroundPriorityRunnable.java ? 0.00% ?
    BatteryState.java ? 0.00% ?
    BlockingAnalyticsEventLogger.java ? 0.00% ?
    BreadcrumbAnalyticsEventReceiver.java ? 0.00% ?
    BreadcrumbHandler.java ? 0.00% ?
    BreadcrumbSource.java ? 0.00% ?
    BytesBackedNativeSessionFile.java ? 0.00% ?
    CLSUUID.java ? 0.00% ?
    CachedSettingsIo.java ? 0.00% ?
    CommonUtils.java ? 0.00% ?
    CrashlyticsAnalyticsListener.java ? 0.00% ?
    CrashlyticsBackgroundWorker.java ? 0.00% ?
    CrashlyticsController.java ? 0.00% ?
    CrashlyticsCore.java ? 0.00% ?
    CrashlyticsFileMarker.java ? 0.00% ?
    CrashlyticsLifecycleEvents.java ? 0.00% ?
    CrashlyticsNativeComponent.java ? 0.00% ?
    CrashlyticsOriginAnalyticsEventLogger.java ? 0.00% ?
    CrashlyticsRegistrar.java ? 0.00% ?
    CrashlyticsReport.java ? 0.00% ?
    CrashlyticsReportDataCapture.java ? 0.00% ?
    CrashlyticsReportJsonTransform.java ? 0.00% ?
    CrashlyticsReportPersistence.java ? 0.00% ?
    CrashlyticsReportWithSessionId.java ? 0.00% ?
    CrashlyticsUncaughtExceptionHandler.java ? 0.00% ?
    CurrentTimeProvider.java ? 0.00% ?
    CustomKeysAndValues.java ? 0.00% ?
    DataCollectionArbiter.java ? 0.00% ?
    DataTransportCrashlyticsReportSender.java ? 0.00% ?
    DefaultSettingsJsonTransform.java ? 0.00% ?
    DefaultSettingsSpiCall.java ? 0.00% ?
    DeliveryMechanism.java ? 0.00% ?
    DisabledBreadcrumbSource.java ? 0.00% ?
    ExecutorUtils.java ? 0.00% ?
    FeaturesSettingsData.java ? 0.00% ?
    FileBackedNativeSessionFile.java ? 0.00% ?
    FileLogStore.java ? 0.00% ?
    FileStore.java ? 0.00% ?
    FileStoreImpl.java ? 0.00% ?
    FirebaseCrashlytics.java ? 0.00% ?
    HttpGetRequest.java ? 0.00% ?
    HttpRequestFactory.java ? 0.00% ?
    HttpResponse.java ? 0.00% ?
    IdManager.java ? 0.00% ?
    ImmutableList.java ? 0.00% ?
    InstallIdProvider.java ? 0.00% ?
    InstallerPackageNameProvider.java ? 0.00% ?
    LogFileManager.java ? 0.00% ?
    Logger.java ? 0.00% ?
    MetaDataStore.java ? 0.00% ?
    MiddleOutFallbackStrategy.java ? 0.00% ?
    MiddleOutStrategy.java ? 0.00% ?
    NativeSessionFile.java ? 0.00% ?
    NativeSessionFileGzipper.java ? 0.00% ?
    NativeSessionFileProvider.java ? 0.00% ?
    ProviderProxyNativeComponent.java ? 0.00% ?
    QueueFile.java ? 0.00% ?
    QueueFileLogStore.java ? 0.00% ?
    RemoveRepeatsStrategy.java ? 0.00% ?
    ResourceUnityVersionProvider.java ? 0.00% ?
    ResponseParser.java ? 0.00% ?
    SessionReportingCoordinator.java ? 0.00% ?
    SessionSettingsData.java ? 0.00% ?
    Settings.java ? 0.00% ?
    SettingsCacheBehavior.java ? 0.00% ?
    SettingsController.java ? 0.00% ?
    SettingsData.java ? 0.00% ?
    SettingsDataProvider.java ? 0.00% ?
    SettingsJsonConstants.java ? 0.00% ?
    SettingsJsonParser.java ? 0.00% ?
    SettingsJsonTransform.java ? 0.00% ?
    SettingsRequest.java ? 0.00% ?
    SettingsSpiCall.java ? 0.00% ?
    SettingsV3JsonTransform.java ? 0.00% ?
    StackTraceTrimmingStrategy.java ? 0.00% ?
    SystemCurrentTimeProvider.java ? 0.00% ?
    TrimmedThrowableData.java ? 0.00% ?
    UnavailableAnalyticsEventLogger.java ? 0.00% ?
    UnityVersionProvider.java ? 0.00% ?
    UserMetadata.java ? 0.00% ?
    Utils.java ? 0.00% ?

Test Logs

Notes

HTML coverage reports can be produced locally with ./gradlew <product>:checkCoverage.
Report files are located at <product-build-dir>/reports/jacoco/.

Head commit (984758a8) is created by Prow via merging commits: ca1ab42 47511bc.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Apr 26, 2021 •
edited
Loading

Binary Size Report

Affected SDKs

  • firebase-annotations

    Type Base (ca1ab42) Head (984758a8) Diff
    apk (aggressive) ? 8.39 kB ? (?)
    apk (release) ? 8.77 kB ? (?)

  • firebase-common

    Type Base (ca1ab42) Head (984758a8) Diff
    aar ? 45.5 kB ? (?)
    apk (aggressive) ? 77.8 kB ? (?)
    apk (release) ? 635 kB ? (?)

  • firebase-components

    Type Base (ca1ab42) Head (984758a8) Diff
    aar ? 41.4 kB ? (?)
    apk (aggressive) ? 8.68 kB ? (?)
    apk (release) ? 29.4 kB ? (?)

  • firebase-crashlytics

    Type Base (ca1ab42) Head (984758a8) Diff
    aar ? 325 kB ? (?)
    apk (aggressive) ? 194 kB ? (?)
    apk (release) ? 823 kB ? (?)

  • firebase-encoders

    Type Base (ca1ab42) Head (984758a8) Diff
    apk (aggressive) ? 8.68 kB ? (?)
    apk (release) ? 15.3 kB ? (?)

  • firebase-encoders-json

    Type Base (ca1ab42) Head (984758a8) Diff
    aar ? 10.7 kB ? (?)
    apk (aggressive) ? 8.68 kB ? (?)
    apk (release) ? 20.1 kB ? (?)

  • firebase-installations

    Type Base (ca1ab42) Head (984758a8) Diff
    aar ? 54.6 kB ? (?)
    apk (aggressive) ? 79.5 kB ? (?)
    apk (release) ? 658 kB ? (?)

  • firebase-installations-interop

    Type Base (ca1ab42) Head (984758a8) Diff
    aar ? 8.06 kB ? (?)
    apk (aggressive) ? 55.4 kB ? (?)
    apk (release) ? 607 kB ? (?)

  • transport-api

    Type Base (ca1ab42) Head (984758a8) Diff
    aar ? 6.57 kB ? (?)
    apk (aggressive) ? 8.68 kB ? (?)
    apk (release) ? 14.8 kB ? (?)

  • transport-backend-cct

    Type Base (ca1ab42) Head (984758a8) Diff
    aar ? 53.5 kB ? (?)
    apk (aggressive) ? 47.4 kB ? (?)
    apk (release) ? 87.6 kB ? (?)

  • transport-runtime

    Type Base (ca1ab42) Head (984758a8) Diff
    aar ? 149 kB ? (?)
    apk (aggressive) ? 33.1 kB ? (?)
    apk (release) ? 63.7 kB ? (?)

Test Logs

Notes

Head commit (984758a8) is created by Prow via merging commits: ca1ab42 47511bc.

@tejasd
Copy link
Contributor Author

tejasd commented Apr 28, 2021

/test smoke-tests

vywoo
vywoo reviewed May 11, 2021
View reviewed changes
Copy link

@vywoo vywoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tejasd tejasd merged commit e1c565f into crashlytics/anrs May 11, 2021
@tejasd tejasd deleted the td/anr-2 branch May 11, 2021 19:04
@firebase firebase locked and limited conversation to collaborators Jun 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@mrichards mrichards Awaiting requested review from mrichards

1 more reviewer

@vywoo vywoo vywoo left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes Override cla size/M

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tejasd @google-oss-bot @vywoo