Skip to content

Add flag for collecting ANRs to Settings Feature Data #2585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tejasd merged 3 commits into from
Apr 13, 2021
Merged

Add flag for collecting ANRs to Settings Feature Data #2585

tejasd merged 3 commits into from
Apr 13, 2021

Conversation

@tejasd
Copy link
Contributor

@tejasd tejasd commented Apr 13, 2021

No description provided.

@googlebot googlebot added the cla: yes Override cla label Apr 13, 2021
@tejasd tejasd requested review from mrichards and mrober April 13, 2021 20:21
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Apr 13, 2021 •
edited
Loading

Coverage Report

Affected SDKs

No changes between base commit (a056e91) and head commit (7f009cce).

Test Logs

Notes

HTML coverage reports can be produced locally with ./gradlew <product>:checkCoverage.
Report files are located at <product-build-dir>/reports/jacoco/.

Head commit (7f009cce) is created by Prow via merging commits: a056e91 62e8c18.

@tejasd tejasd requested a review from kmandrika April 13, 2021 20:26
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Apr 13, 2021 •
edited
Loading

Binary Size Report

Affected SDKs

  • firebase-crashlytics

    Type Base (a056e91) Head (7f009cce) Diff
    aar 325 kB 325 kB +151 B (+0.0%)
    apk (aggressive) 192 kB 192 kB +80 B (+0.0%)
    apk (release) 818 kB 818 kB -4 B (-0.0%)

Test Logs

Notes

Head commit (7f009cce) is created by Prow via merging commits: a056e91 62e8c18.

mrichards
mrichards approved these changes Apr 13, 2021
View reviewed changes
Copy link
Contributor

@mrichards mrichards left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tejasd tejasd changed the base branch from crashlytics/anrs to master April 13, 2021 20:55
@tejasd tejasd changed the base branch from master to crashlytics/anrs April 13, 2021 20:57
@tejasd tejasd merged commit 9926a1b into crashlytics/anrs Apr 13, 2021
@tejasd tejasd deleted the td/anr branch April 13, 2021 20:58
@firebase firebase locked and limited conversation to collaborators May 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@mrichards mrichards mrichards approved these changes

@mrober mrober Awaiting requested review from mrober

@kmandrika kmandrika Awaiting requested review from kmandrika

Assignees

No one assigned

Labels

cla: yes Override cla size/M

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tejasd @google-oss-bot @mrichards @googlebot