'?' is now an illegal character for the REST API

[Bien-CV]

Having a '?' character in a path raised an ApiCallError (405 Client Error: Method Not Allowed for url: -fakeURLwith?-.json Reason: append .json to your request URI to use the REST API. ).

It is indeed not the right error.

This pull request allows the correct error to be raised ( ValueError : 'Invalid path: "{0}". Path contains illegal characters.' ).

[googlebot]

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.

---

What to do if you already signed the CLA

Individual signers

• It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

• Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
• The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
• The email used to register you as an authorized contributor must also be attached to your GitHub account.

[Bien-CV]

CLA signed.

[googlebot]

CLAs look good, thanks!

[hiranya911]

@Bien-CV thanks for the PR. However, ? is a valid path character in Firebase Realtime Database. I wonder if we should do something special to handle them in Python.

@rockwotj any thoughts on how to fix this? Simple URL encoding of the "?" is not enough it seems.

[rockwotj]

@hiranya911 we've got a really bad bug that's been out for 5 years or something. We have broken behavior with URL decoding where we accidentally do it twice. That breaks most of these things, and we don't have a good fix because there are apps that rely on the broken behavior. We're trying to come up with a way to fix it.

[hiranya911]

Thanks @rockwotj. In that case would it make sense to accept this PR and treat ? as an invalid path character (at least for the time being)? Given that they don't work anyway when used in a path, I don't see the harm.

[Bien-CV]

The '?' issue bothers all developers trying to use URLs as keys in firebase.

[hiranya911]

@rockwotj just wanted to ping you again on this. Is it reasonable to not accept ? as a valid path character (at least until the issue in the server-side gets resolved)?

[rockwotj]

There is no harm, I'm fine with it. I'll ping this thread when the issue is deployed.

[hiranya911]

LGTM