Added WebpushNotification.Builder API with additional Webpush parameters #193
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| /** | ||
| * Sets any arbitrary data that should be associated with the notification. | ||
| * | ||
| * @param data A json-serializable object. |
| @@ -35,12 +35,12 @@ | |||
| private final Map<String, String> data; | |||
|
|
|||
| @Key("notification") | |||
| private final WebpushNotification notification; | |||
| private final Map<String, Object> notification; | |||
There was a problem hiding this comment.
Sorry, I don't quite follow where this private fields are ever read. Can you elaborate?
I am asking this because I liked using WebpushNotification here better but I can see reason why the Map would be more appropriate.
There was a problem hiding this comment.
All these get serialized into JSON. We now need a Map because the notification now allows arbitrary key-value pairs (via putCustomData()).
hiranya911
commented
Jul 26, 2018
| @@ -35,12 +35,12 @@ | |||
| private final Map<String, String> data; | |||
|
|
|||
| @Key("notification") | |||
| private final WebpushNotification notification; | |||
| private final Map<String, Object> notification; | |||
There was a problem hiding this comment.
All these get serialized into JSON. We now need a Map because the notification now allows arbitrary key-value pairs (via putCustomData()).
| /** | ||
| * Sets any arbitrary data that should be associated with the notification. | ||
| * | ||
| * @param data A json-serializable object. |
schmidt-sebastian
approved these changes
Jul 27, 2018
mmermerkaya
approved these changes
Jul 30, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FCM Webpush API now supports additional parameters as defined in https://developer.mozilla.org/en-US/docs/Web/API/notification/Notification
Related to firebase/firebase-admin-node#305