Skip to content

Conversation

jonathanedey
Copy link
Contributor

Updated the integration test project setup instructions to be more accurate to the current setup flow.

@jonathanedey jonathanedey marked this pull request as ready for review November 16, 2023 15:53
Copy link
Contributor

@egilmorez egilmorez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG with one more nit that I found (and should be applied in similar PRs). Thanks!

CONTRIBUTING.md Outdated
7. Ensure your service account has the **Firebase Authentication Admin** role. This is required
to ensure that exported user records contain the password hashes of the user accounts:
1. Go to [Google Cloud console | IAM & admin](https://console.cloud.google.com/iam-admin).
2. Find your service account in the list. If not added click the **pencil** icon to edit its
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry if I missed this earlier for Java, but -- unless the label "pencil" is actually in the GUI, this wouldn't be bolded. I think just plain old "click the pencil icon" will work fine.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good I'll update those!

@jonathanedey jonathanedey merged commit e4f5a55 into master Dec 19, 2023
@jonathanedey jonathanedey deleted the je-project-setup branch December 19, 2023 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants