Skip to content

Conversation

ScruffyProdigy
Copy link
Contributor

Provides an option for developers to specify the OAuth response type for their OIDC provider (either one of these can be set:):

  • id_token
  • code (if set, must also set the client secret)

@ScruffyProdigy
Copy link
Contributor Author

@lsirac

@lsirac lsirac changed the title Enable OIDC auth code flow feat(auth): enables OIDC auth code flow Jun 2, 2021
@lsirac lsirac requested a review from hiranya911 June 2, 2021 21:16
Copy link
Contributor

@hiranya911 hiranya911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks mostly good. Just a few suggestions, with main issue being some deviations from the API proposal.

Copy link
Contributor

@hiranya911 hiranya911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. This looks great. Just one more comment on naming conventions (sorry for missing it in my previous review).

Copy link
Contributor

@hiranya911 hiranya911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM 👍

@lsirac lsirac requested review from egilmorez and kevinthecheung and removed request for egilmorez June 15, 2021 17:53
ScruffyProdigy and others added 12 commits June 15, 2021 14:38
@lsirac lsirac merged commit d3a290a into firebase:master Jun 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants