-
Notifications
You must be signed in to change notification settings - Fork 144
feat(auth): enables OIDC auth code flow #299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks mostly good. Just a few suggestions, with main issue being some deviations from the API proposal.
FirebaseAdmin/FirebaseAdmin/Auth/Providers/OidcProviderConfig.cs
Outdated
Show resolved
Hide resolved
FirebaseAdmin/FirebaseAdmin/Auth/Providers/OidcProviderConfig.cs
Outdated
Show resolved
Hide resolved
FirebaseAdmin/FirebaseAdmin.Tests/Auth/Providers/OidcProviderConfigTest.cs
Show resolved
Hide resolved
FirebaseAdmin/FirebaseAdmin.IntegrationTests/Auth/AbstractOidcProviderConfigTest.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. This looks great. Just one more comment on naming conventions (sorry for missing it in my previous review).
FirebaseAdmin/FirebaseAdmin/Auth/Providers/OidcProviderConfig.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! LGTM 👍
FirebaseAdmin/FirebaseAdmin.Tests/Auth/Providers/OidcProviderConfigTest.cs
Show resolved
Hide resolved
FirebaseAdmin/FirebaseAdmin.Tests/Auth/Providers/OidcProviderConfigTest.cs
Outdated
Show resolved
Hide resolved
FirebaseAdmin/FirebaseAdmin.Tests/Auth/Providers/OidcProviderConfigTest.cs
Show resolved
Hide resolved
FirebaseAdmin/FirebaseAdmin.Tests/Auth/Providers/OidcProviderConfigTest.cs
Outdated
Show resolved
Hide resolved
FirebaseAdmin/FirebaseAdmin/Auth/Providers/OidcProviderConfig.cs
Outdated
Show resolved
Hide resolved
FirebaseAdmin/FirebaseAdmin/Auth/Providers/OidcProviderConfigArgs.cs
Outdated
Show resolved
Hide resolved
FirebaseAdmin/FirebaseAdmin/Auth/Providers/OidcProviderConfigArgs.cs
Outdated
Show resolved
Hide resolved
FirebaseAdmin/FirebaseAdmin/Auth/Providers/OidcProviderConfigArgs.cs
Outdated
Show resolved
Hide resolved
FirebaseAdmin/FirebaseAdmin/Auth/Providers/OidcProviderConfigArgs.cs
Outdated
Show resolved
Hide resolved
FirebaseAdmin/FirebaseAdmin/Auth/Providers/OidcProviderConfigArgs.cs
Outdated
Show resolved
Hide resolved
…onfigTest.cs Co-authored-by: Kevin Cheung <[email protected]>
…onfigTest.cs Co-authored-by: Kevin Cheung <[email protected]>
…onfigTest.cs Co-authored-by: Kevin Cheung <[email protected]>
…onfigTest.cs Co-authored-by: Kevin Cheung <[email protected]>
Co-authored-by: Kevin Cheung <[email protected]>
…rgs.cs Co-authored-by: Kevin Cheung <[email protected]>
…rgs.cs Co-authored-by: Kevin Cheung <[email protected]>
…rgs.cs Co-authored-by: Kevin Cheung <[email protected]>
…rgs.cs Co-authored-by: Kevin Cheung <[email protected]>
…rgs.cs Co-authored-by: Kevin Cheung <[email protected]>
Provides an option for developers to specify the OAuth response type for their OIDC provider (either one of these can be set:):