Skip to content

fix(auth): adds missing EMAIL_NOT_FOUND error code #298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 4, 2021
Merged

fix(auth): adds missing EMAIL_NOT_FOUND error code #298

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c9d5383
fix(auth): adds missing EMAIL_NOT_FOUND error code
bojeil-google May 3, 2021
ed1ee48
Addresses review comments.
bojeil-google May 3, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions FirebaseAdmin/FirebaseAdmin.Tests/Auth/AuthErrorHandlerTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,12 @@ public class AuthErrorHandlerTest
ErrorCode.NotFound,
AuthErrorCode.UserNotFound,
},
new object[]
{
"EMAIL_NOT_FOUND",
ErrorCode.NotFound,
AuthErrorCode.EmailNotFound,
},
};

[Theory]
Expand Down
7 changes: 7 additions & 0 deletions FirebaseAdmin/FirebaseAdmin/Auth/AuthErrorCode.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,5 +98,12 @@ public enum AuthErrorCode
/// Tenant ID in a token does not match.
/// </summary>
TenantIdMismatch,

/// <summary>
/// No user record found for the given email, typically raised when
/// generating a password reset link using an email for a user that
/// is not already registered.
/// </summary>
EmailNotFound,
}
}
7 changes: 7 additions & 0 deletions FirebaseAdmin/FirebaseAdmin/Auth/AuthErrorHandler.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,13 @@ internal sealed class AuthErrorHandler
AuthErrorCode.EmailAlreadyExists,
"The user with the provided email already exists")
},
{
"EMAIL_NOT_FOUND",
new ErrorInfo(
ErrorCode.NotFound,
AuthErrorCode.EmailNotFound,
"No user record found for the given email")
},
{
"INVALID_DYNAMIC_LINK_DOMAIN",
new ErrorInfo(
Expand Down