Skip to content

Conversation

hiranya911
Copy link
Contributor

@hiranya911 hiranya911 commented Jul 23, 2020

Copy link
Member

@lahirumaramba lahirumaramba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Left one comment.


while (await enumerator.MoveNext())
{
OidcProviderConfig saml = enumerator.Current;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: should we call this OidcProviderConfig oidc = ...?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. Done.

@hiranya911 hiranya911 merged commit 227a988 into master Jul 24, 2020
@hiranya911 hiranya911 deleted the idp-config-snippets branch July 24, 2020 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants