Skip to content

feat(auth): Added CreateSessionCookieAsync() API #176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 29, 2020
Merged

feat(auth): Added CreateSessionCookieAsync() API #176

merged 2 commits into from
Apr 29, 2020

Conversation

hiranya911
Copy link
Contributor

@hiranya911 hiranya911 commented Apr 25, 2020 •
edited
Loading 

Task<string> CreateSessionCookieAsync(string idToken, SessionCookieOptions options)

class SessionCookieOptions
  TimeSpan ExpiresIn

RELEASE NOTE: Added CreateSessionCookieAsync() method for creating Firebase session cookies from valid ID tokens.

lahirumaramba
lahirumaramba approved these changes Apr 27, 2020
View reviewed changes
Copy link
Member

@lahirumaramba lahirumaramba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hiranya911 hiranya911 requested a review from egilmorez April 27, 2020 19:40
@hiranya911 hiranya911 assigned egilmorez and unassigned hiranya911 Apr 27, 2020
@hiranya911
Copy link
Contributor Author

Hi @egilmorez. Please review for API docs in FirebaseAuth and SessionCookieOptions.

kevinthecheung
kevinthecheung approved these changes Apr 29, 2020
View reviewed changes
Copy link
Collaborator

@kevinthecheung kevinthecheung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hiranya911 hiranya911 assigned hiranya911 and unassigned egilmorez Apr 29, 2020
@hiranya911 hiranya911 removed the request for review from egilmorez April 29, 2020 21:37
@hiranya911 hiranya911 merged commit 754a89e into master Apr 29, 2020
@hiranya911 hiranya911 deleted the hkj-create-cookie branch April 29, 2020 21:37
@hiranya911
Copy link
Contributor Author

Resolves #160

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lahirumaramba lahirumaramba lahirumaramba approved these changes

@kevinthecheung kevinthecheung kevinthecheung approved these changes

Assignees

@hiranya911 hiranya911

Labels

release-note

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@hiranya911 @lahirumaramba @kevinthecheung @egilmorez