Skip to content

Conversation

hiranya911
Copy link
Contributor

@hiranya911 hiranya911 commented Apr 13, 2020

Ability to revoke previously issued refresh tokens by setting the validSince property on user accounts.

Resolves #150

RELEASE NOTE: Added RevokeRefreshTokensAsync() API for revoking any previously issued refresh tokens to a user.

Copy link
Member

@lahirumaramba lahirumaramba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one comment

RetryOptions = args.RetryOptions,
});
this.baseUrl = string.Format(IdTooklitUrl, args.ProjectId);
this.clock = args.Clock ?? SystemClock.Default;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did we add tests where we pass the Clock in Args?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. All tests in FirebaseUserManagerTest.

@hiranya911 hiranya911 merged commit 6c51b93 into master Apr 14, 2020
@hiranya911 hiranya911 deleted the hkj-revoke-tokens branch April 14, 2020 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Revoking refresh tokens

2 participants