Legacy API Deprecation for FCM

[euantorano]

We've received an email yesterday regarding deprecation of the legacy API for FCM. It links to an FAQ entry, which says to migrate usages of SendMulticastAsync to SendEachForMulticastAsync.

I see this method was added in commit 74bd9e5, but there has not been a release tagged since 24/03/2022.

Is there any chance a new release might be tagged and pushed to NuGet at some point soon (preferably before the API cutoff on 20/06/2024...)?

[google-oss-bot]

I found a few problems with this issue:

• I couldn't figure out how to label this issue, so I've labeled it for a human to triage. Hang tight.
• This issue does not seem to follow the issue template. Make sure you provide all the required information.

[euantorano]

I note that this seems to affect every version of the Admin SDK, including:

• .NET (this issue)
• Go
• Java (functions implemented in firebase/firebase-admin-java@d1baee3 but no release tagged)
• Python (functions implemented in firebase/firebase-admin-python@4323ed8 but no release tagged)

In fact, the only version that seems OK is Node (functions implemented in firebase/firebase-admin-node@0da72ef and seemingly included in release 11.9.0)

[fu-mybeepr]

I was wondering the same. The FAQ page specifically says >= 2.4.0 for .Net, but apparently 2.4.0 is not released on either GitHub or Nuget.

[tonsnoei]

Additional to the above questions and important in relation to the performance of the library with this new (batch/multicast replacing) functionality:

I saw that in 2.4.0 the suggested usage of HTTP/2 for the HttpClient is not implemented yet. Right?

I am not sure how the HttpClient behaves. Does it automatically use HTTP/2 in some situations? From what I understand you have to set the handler of the HttpClient explicitly in the following way:

DefaultRequestVersion = new Version(2, 0); // Use HTTP/2

Just wondering...

Furthermore, keep up the good work!

[ewfian]

Additional to the above questions and important in relation to the performance of the library with this new (batch/multicast replacing) functionality:

I saw that in 2.4.0 the suggested usage of HTTP/2 for the HttpClient is not implemented yet. Right?

I am not sure how the HttpClient behaves. Does it automatically use HTTP/2 in some situations? From what I understand you have to set the handler of the HttpClient explicitly in the following way:

DefaultRequestVersion = new Version(2, 0); // Use HTTP/2

Just wondering...

Furthermore, keep up the good work!

Same question here.
From this doc, the default version is 1.1 on .NET 6

In .NET Core, the default message version differs based on the version you're using. .NET Core 2.1 changed the default value from 1.1 to 2.0. In .NET Core 3.0, the default value was reverted back to 1.1.
https://learn.microsoft.com/en-us/dotnet/api/system.net.http.httprequestmessage.version?view=net-6.0#property-value

FirebaseAdmin supports netstandard2.0, while netstandard2.0 compatible with .NET Core 2.1 and 2.2
https://github.com/firebase/firebase-admin-dotnet/blob/bc7bc090a0636b4c7487dd530511139ec60b167a/FirebaseAdmin/FirebaseAdmin/FirebaseAdmin.csproj#L5C30-L5C30
https://learn.microsoft.com/en-us/dotnet/standard/net-standard?tabs=net-standard-2-0

According this comment, the default behavior will vary between different .net versions

The HTTP message version. The default value is 1.1, unless you're targeting .NET Core 2.1 or 2.2. In that case, the default value is 2.0.

[euantorano]

Now that 2.4.0 has been released, I've updated my project to it.

It looks like SendMulticastAsync hasn't been marked as obsolete/deprecated as the ObsoleteAttribute is commented out:

firebase-admin-dotnet/FirebaseAdmin/FirebaseAdmin/Messaging/FirebaseMessaging.cs

Line 422 in bc7bc09

/// [Obsolete(Use <see cref="SendEachForMulticastAsync(MulticastMessage)"/> instead)]

It seems the attribute was added but commented out in 74bd9e5 - this is fairly easy to miss as Visual Studio by default continues the block comment when you enter a new line at the end.

[lahirumaramba]

Hey folks, you are right there was a delay on the .NET release and the new batch send APIs are now available in v2.4.0
https://firebase.google.com/support/release-notes/admin/dotnet#version_240_-_12_july_2023

Thank you for flagging the issue with the Obsolete tag! @Doris-Ge could you take a look at the ObsoleteAttribute when you get a chance, please? Thanks!

[Doris-Ge]

Thank you for flagging the issue with the Obsolete tag! @Doris-Ge could you take a look at the ObsoleteAttribute when you get a chance, please? Thanks!

Sure. I think I misunderstood the usage of Obsolete.

Thanks for flagging the issue! Will fix it.