README for SwiftUI alpha release #1251
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
morganchen12
approved these changes
May 8, 2025
Contributor
morganchen12
left a comment
morganchen12
left a comment
There was a problem hiding this comment.
LGTM with some small changes.
| shouldAutoUpgradeAnonymousUsers: Bool = false, | ||
| customStringsBundle: Bundle? = nil, | ||
| tosUrl: URL = URL(string: "https://example.com/tos")!, | ||
| privacyPolicyUrl: URL = URL(string: "https://example.com/privacy")!, |
Contributor
There was a problem hiding this comment.
Maybe these parameters shouldn't have default values, or should be nullable. It would be an error to ship your app with these default values.
(This can be addressed in a separate PR)
Member
Author
There was a problem hiding this comment.
Good point - I think nullable is right. I'll address in separate PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
README for alpha release. Documentation on how to install, setup and configure and what API is available.