Skip to content

chore: use minSdk=23 for auth, and minSdk=21 for other modules #2196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 19, 2025
Merged

chore: use minSdk=23 for auth, and minSdk=21 for other modules #2196

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d45a9fb
chore: use minSdk=23 for auth, and minSdk=21 for other modules
thatfiredev Mar 18, 2025
4ccf93a
Merge branch 'version-9.1.0-dev' into rpf/decouple-minSdk
thatfiredev Mar 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ android {
namespace = "com.firebase.uidemo"

defaultConfig {
minSdk = Config.SdkVersions.min
minSdk = 23
targetSdk = Config.SdkVersions.target

versionName = Config.version
Expand Down
5 changes: 3 additions & 2 deletions auth/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,9 @@ android {
namespace = "com.firebase.ui.auth"

defaultConfig {
minSdk = Config.SdkVersions.min
targetSdk =Config.SdkVersions.target
// Auth requires a higher minSdk than the current Config.SdkVersions.min
minSdk = 23
targetSdk = Config.SdkVersions.target

buildConfigField("String", "VERSION_NAME", "\"${Config.version}\"")

Expand Down
4 changes: 3 additions & 1 deletion buildSrc/src/main/kotlin/Config.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,9 @@ object Config {
object SdkVersions {
const val compile = 34
const val target = 34
const val min = 23
// Note that auth uses a different minSdk than this and
// should be changed in auth/build.gradle.kts
const val min = 21
}

object Plugins {
Expand Down