Skip to content

Conversation

@puf
Copy link
Contributor

@puf puf commented May 22, 2020

Hey there! So you want to contribute to FirebaseUI? Before you file this pull request, follow these steps:

  • Read the contribution guidelines.
  • Run ./gradlew check to ensure the Travis build passes.
  • If this has been discussed in an issue, make sure to mention the issue number here. If not, go file an issue about this to make sure this is a desirable change.
  • If this is a new feature please co-ordinate with someone on FirebaseUI-iOS to make sure that we can implement this on both platforms and maintain feature parity.

@puf puf requested a review from samtstern as a code owner May 22, 2020 15:02
@samtstern
Copy link
Contributor

Looks like you got hit by the same build issue as #1774 ...

@samtstern samtstern merged commit 6d41fb2 into master May 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants