#1658: Fix for using custom Layout icm Email Link #1661
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@Entreco this works great for me! I just tested it. Thanks for contributing to FirebaseUI. I am happy to merge this now if you're ready for it. |
Contributor
Author
|
Thanks for the prompt response! I'm ready if you are ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #1658 .
After this is merged, it is possible to use the EmailLink setting in combination with a custom layout.
This is a work-around at best, because ideally, someone would spend some time to refactor the EmailLink settings. I think it is confusing, that by calling setEmailLinkEnabled(), the ID of the provider is changed (without) any notice.
Let me know your thoughts.