Escape regex tokens within field names #38
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #38 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 14 15 +1
Lines 157 159 +2
Branches 34 34
=====================================
+ Hits 157 159 +2
Continue to review full report at Codecov.
|
SpOOnman
reviewed
Sep 20, 2019
src/utils.js
Outdated
| @@ -0,0 +1,3 @@ | |||
| // @flow | |||
| export const escapeRegexTokens = (str: string): string => | |||
| str.replace(/([.\-[])/g, '\\$1') | |||
Contributor
There was a problem hiding this comment.
I've found this robust regex on MDN: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Guide/Regular_Expressions#Escaping - maybe use this one with a comment where is it taken from?
Contributor
|
This solution works for me too and I've suggested even more complex regex to improve this fix. |
Member
|
Published in |
Contributor
|
Thanks @erikras ! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #37
@erikras I just copied the suitable test-case and adjusted it to demonstrate the issue. Let me know if I should structure the tests differently. 👍