Skip to content

Code Quality: Replaced the StartSTA helpers with STATask.Run #17377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 1, 2025
Merged

Code Quality: Replaced the StartSTA helpers with STATask.Run #17377

merged 1 commit into from
Aug 1, 2025

Conversation

@0x5bfa
Copy link
Member

@0x5bfa 0x5bfa commented Jul 31, 2025

Resolved / Related Issues

Steps used to test these changes

  1. Open Files app
  2. Do some file operations and check if they go successfully

@0x5bfa
Copy link
Member Author

0x5bfa commented Jul 31, 2025

Ready to merge.

@yaira2 yaira2 requested a review from hishitetsu July 31, 2025 14:28
@yaira2 yaira2 added the ready for review Pull requests that are ready for review label Jul 31, 2025
hishitetsu
hishitetsu approved these changes Aug 1, 2025
View reviewed changes
Copy link
Member

@hishitetsu hishitetsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed ready for review Pull requests that are ready for review labels Aug 1, 2025
@yaira2 yaira2 merged commit c1d9e84 into files-community:main Aug 1, 2025
6 checks passed
@0x5bfa 0x5bfa deleted the 5bfa/CQ-StartSTA branch August 1, 2025 19:00
yaira2 added a commit that referenced this pull request Aug 4, 2025
@yaira2
Revert "Code Quality: Replaced the StartSTA helpers with STATask.Run (#…
b8ac66d 
…17377)"

This reverts commit c1d9e84.
yaira2 added a commit that referenced this pull request Aug 4, 2025
@yaira2
Revert "Code Quality: Replaced the StartSTA helpers with STATask.Run (#…
6b35a21 
…17377)"

This reverts commit c1d9e84.
@0x5bfa 0x5bfa restored the 5bfa/CQ-StartSTA branch August 5, 2025 18:17
@0x5bfa 0x5bfa mentioned this pull request Aug 7, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@hishitetsu hishitetsu hishitetsu approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

ready to merge Pull requests that are approved and ready to merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@0x5bfa @hishitetsu @yaira2