Skip to content

Conversation

@gave92
Copy link
Member

@gave92 gave92 commented Dec 22, 2024

Resolved / Related Issues

To prevent extra work, all changes to the Files codebase must link to an approved issue marked as Ready to build. Please insert the issue number following the hashtag with the issue number that this Pull Request resolves.

Added the missing code for setting a tag when a file is dropped on the tags sidebar section.

Steps used to test these changes

Stability is a top priority for Files and all changes are required to go through testing before being merged into the repo. Please include a list of steps that you used to test this PR.

  1. Drag&drop files from the file list to a tag on the sidebar

@yaira2 yaira2 added the ready for review Pull requests that are ready for review label Dec 22, 2024
@yaira2 yaira2 changed the title Feature: Allow to apply tags by dropping on the sidebar Feature: Added back support for applying tags by dropping them on the sidebar Dec 22, 2024
@yaira2 yaira2 changed the title Feature: Added back support for applying tags by dropping them on the sidebar Feature: Added back support for applying tags by dropping files on the sidebar Dec 22, 2024
Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed ready for review Pull requests that are ready for review labels Dec 22, 2024
@yaira2 yaira2 merged commit aaefa0a into files-community:main Dec 22, 2024
6 checks passed
@gave92 gave92 deleted the issue_16637 branch December 22, 2024 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready to merge Pull requests that are approved and ready to merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: Drag to apply tags doesn't work

2 participants