Skip to content

Conversation

@0x5bfa
Copy link
Member

@0x5bfa 0x5bfa commented Dec 6, 2024

Summary

We removed Store, Preview and Stable configurations in #16566. This is follow-up PR for it in order to remove leftovers.

We now have only Debug and Release.
While we have 4 release destinations in Release configuration: SideloadPreview, SideloadStable, StorePreview and StoreStable, these are configured within our CD pipeline for the simplicity in project configurations since these have differences only in packaging and publish destination.

@0x5bfa 0x5bfa changed the title 5bfa/gh config followup Code Quality: Removed unnecessary configurations Dec 6, 2024
@0x5bfa
Copy link
Member Author

0x5bfa commented Dec 6, 2024

Should I include follow up for CD for store submission to add a checkbox

@yaira2
Copy link
Member

yaira2 commented Dec 6, 2024

Should I include follow up for CD for store submission to add a checkbox

That would be great! Please open a separate PR for this.

@0x5bfa
Copy link
Member Author

0x5bfa commented Dec 10, 2024

PTAL

<GenerateAppInstallerFile>False</GenerateAppInstallerFile>
<AppxAutoIncrementPackageRevision>False</AppxAutoIncrementPackageRevision>
<AppxSymbolPackageEnabled>True</AppxSymbolPackageEnabled>
<AppxBundlePlatforms>x86|x64|arm64</AppxBundlePlatforms>
Copy link
Member

@yaira2 yaira2 Dec 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should keep x86

@yaira2 yaira2 added the changes requested Changes are needed for this pull request label Dec 11, 2024
@yaira2 yaira2 closed this Jan 14, 2025
@0x5bfa 0x5bfa deleted the 5bfa/GH-ConfigFollowup branch February 26, 2025 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changes requested Changes are needed for this pull request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants