Skip to content

Conversation

@yaira2
Copy link
Member

@yaira2 yaira2 commented Nov 16, 2023

Resolved / Related Issues

  • Fixed com exception when setting wallpaper

System.Runtime.InteropServices.COMException: Retrieving the COM class factory for component with CLSID {C2CF3110-460E-4FC1-B9D0-8A1C0C9CC4BD} failed

@yaira2 yaira2 added the ready for review Pull requests that are ready for review label Nov 16, 2023
@yaira2 yaira2 changed the title Fix: Fixed com exception when setting wallpaper Fix: Fixed potential Com Exception when setting wallpaper Nov 16, 2023
@yaira2 yaira2 changed the title Fix: Fixed potential Com Exception when setting wallpaper Fix: Fixed potential Com Exception when setting the wallpaper Nov 16, 2023
@yaira2 yaira2 changed the title Fix: Fixed potential Com Exception when setting the wallpaper Fix: Fixed potential COMException when setting the wallpaper Nov 16, 2023
Copy link
Member

@hishitetsu hishitetsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't it be better to modify SetSlideshow in the same way?

@yaira2 yaira2 requested a review from hishitetsu November 17, 2023 01:08
Copy link
Member

@hishitetsu hishitetsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might want to make the same correction to LockScreen.SetImageFileAsync just to be safe.

@yaira2
Copy link
Member Author

yaira2 commented Nov 17, 2023

You might want to make the same correction to LockScreen.SetImageFileAsync just to be safe.

I thought about it, but it's a different API. It might be worth leaving this alone in case there is an issue that needs to be handled differently.

Copy link
Member

@hishitetsu hishitetsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed ready for review Pull requests that are ready for review labels Nov 17, 2023
@yaira2 yaira2 merged commit 4c5d0f2 into main Nov 17, 2023
@yaira2 yaira2 deleted the ya/WallpaperComException branch November 17, 2023 01:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready to merge Pull requests that are approved and ready to merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants