Skip to content

Code Quality: Deleted duplicate string resources #11469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 26, 2023
Merged

Code Quality: Deleted duplicate string resources #11469

merged 1 commit into from
Feb 26, 2023

Conversation

@hishitetsu
Copy link
Member

@hishitetsu hishitetsu commented Feb 26, 2023

Resolved / Related Issues
Items resolved / related issues by this PR.

Validation
How did you test these changes?

  • Built and ran the app
  • Tested the changes for accessibility

Details

  • Duplicate resources were unified into one with a more generic key name.
  • If a generic key name is not available, it has been changed to a generic key name. Key names for some commonly used resources have also been changed, so they will require retranslation.
  • If the code depends on a key name, that key name is left untouched.

yaira2
yaira2 approved these changes Feb 26, 2023
View reviewed changes
Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 added the ready to merge Pull requests that are approved and ready to merge label Feb 26, 2023
@yaira2 yaira2 merged commit 9669ad6 into files-community:main Feb 26, 2023
@hishitetsu hishitetsu deleted the DeleteDuplicates branch February 26, 2023 04:25
@ferrariofilippo ferrariofilippo mentioned this pull request Mar 7, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yaira2 yaira2 yaira2 approved these changes

Assignees

No one assigned

Labels

ready to merge Pull requests that are approved and ready to merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Code Quality: Delete duplicate string resources

2 participants

@hishitetsu @yaira2